Fix all docpaths to unix format paths #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavoudEshtehari
added
the
➕ Code Health
DavoudEshtehari
requested review from
JRahnama,
Kaur-Parminder and
DavoudEshtehari
DavoudEshtehari
approved these changes
Jan 10, 2022
|
This is the result of find and replace on a very specific doc string and the library won't compile if the paths are wrong. Given that the CI is green and this cannot cause any behavioural changes just how much reviewing does it need? |
JRahnama
approved these changes
Jan 14, 2022
I had to count every single slash and period. Jk, approved. |
johnnypham
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple find-replace on windows style paths to unix style paths. This will make it easier to see code differences in the large files that need merging like SqlDataReader.
@DavoudEshtehari this contributes to merge,