Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to shared -SqlInternalTransaction #1346

Merged
merged 13 commits into from
Mar 9, 2022
Merged

Move to shared -SqlInternalTransaction #1346

merged 13 commits into from
Mar 9, 2022

Conversation

Kaur-Parminder
Copy link
Contributor

This is part of #1261 . Move the code to common folder.

@Kaur-Parminder Kaur-Parminder added the ➕ Code Health Issues/PRs that are targeted to source code quality improvements. label Oct 13, 2021
@Kaur-Parminder Kaur-Parminder added this to the 4.0.0-preview3 milestone Oct 13, 2021
@Kaur-Parminder Kaur-Parminder mentioned this pull request Oct 13, 2021
Open
DavoudEshtehari
DavoudEshtehari reviewed Oct 15, 2021
View reviewed changes
Copy link
Contributor

@DavoudEshtehari DavoudEshtehari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The _transactionType can be readonly.
  • Naming violation : private static int _objectTypeCount; // EventSource counter

src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj Outdated Show resolved Hide resolved
src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj Outdated Show resolved Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlInternalTransaction.cs Show resolved Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlInternalTransaction.cs Show resolved Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlInternalTransaction.cs Outdated Show resolved Hide resolved
@cheenamalhotra cheenamalhotra removed this from the 4.0.0-preview3 milestone Oct 16, 2021
@JRahnama JRahnama added this to the 5.0.0-preview1 milestone Dec 7, 2021
@Kaur-Parminder Kaur-Parminder merged commit 517b162 into dotnet:main Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wraith2 Wraith2 Wraith2 left review comments

@johnnypham johnnypham johnnypham approved these changes

@JRahnama JRahnama JRahnama approved these changes

@DavoudEshtehari DavoudEshtehari DavoudEshtehari approved these changes

Assignees
No one assigned
Labels
➕ Code Health Issues/PRs that are targeted to source code quality improvements.
Projects
None yet
Milestone
5.0.0-preview1
Development

Successfully merging this pull request may close these issues.
6 participants
@Kaur-Parminder @Wraith2 @johnnypham @JRahnama @DavoudEshtehari @cheenamalhotra