-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved SmiXetterAccessMap to shared src folder #1310
Merged
cheenamalhotra
merged 8 commits into
dotnet:main
from
Kaur-Parminder:Move-to-Shared-SmiXetterAccessMap
Oct 19, 2021
Merged
Moved SmiXetterAccessMap to shared src folder #1310
cheenamalhotra
merged 8 commits into
dotnet:main
from
Kaur-Parminder:Move-to-Shared-SmiXetterAccessMap
Oct 19, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code merge for dotnet#1261 Issue for SmiXetterAccessMap class. Added the common code to .Common.cs class.
DavoudEshtehari
added
the
➕ Code Health
Issues/PRs that are targeted to source code quality improvements.
label
Oct 4, 2021
johnnypham
approved these changes
Oct 5, 2021
@Kaur-Parminder can you address the conflict please? |
@JRahnama Done. |
@Kaur-Parminder since the other PRs are merging and we have a lot this may happen more often. Please address the conflicts again. Thanks. |
cheenamalhotra
approved these changes
Oct 18, 2021
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Server/SmiXetterAccessMap.Common.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Server/SmiXetterAccessMap.Common.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code merge for #1261 Issue for SmiXetterAccessMap class. Added the common code to .Common.cs class.