Move to Shared for the Microsoft.Data.SqlClient Reference project

[lcheunglci]

This is related to #1261 but it's not in the list. @cheenamalhotra mentioned that we would like to merge the two reference projects into one as the long term goal is to have one codebase. I merged the netfx csproj into netcore and combined the Microsoft.Data.SqlClient.cs. I ran MSBUILD on release and generated the nuget package and compared it before it was merged. The file size remained the same and I used NuGet Package Explorer to view the contents of the package and it looked the same.

[Wraith2]

The implication of this merge would be that all builds of SqlClient have feature parity, and I didn't think that was the case.

[cheenamalhotra]

Please organize merges better in classes, you can search for method/type by their name before categorizing them and put them in 1 location only.

[cheenamalhotra]

Architecture looks good, few more changes needed.

[Wraith2]

Do we need to have ifdefs and a single file? We could still have netcore and netfx files in the shared location and conditionally include them and I think that would be clearer.

[lcheunglci]

I did notice there's already a Microsoft.Data.SqlClient.NetStandard.cs and Microsoft.Data.SqlClient.Manual.cs. I think having one for net framework in Microsoft.Data.SqlClient.NetFx.cs would make sense for clarity. I'll split it up in the next commit.

[codecov]

Codecov Report

Merging #1307 (1bea873) into main (4e3aa5e) will decrease coverage by 0.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1307      +/-   ##
==========================================
- Coverage   71.54%   71.36%   -0.19%     
==========================================
  Files         291      291              
  Lines       61241    61241              
==========================================
- Hits        43817    43702     -115     
- Misses      17424    17539     +115     

Flag	Coverage Δ
addons	92.38% <ø> (ø)
netcore	74.91% <ø> (-0.18%)	⬇️
netfx	69.19% <ø> (-0.15%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...re/src/Microsoft/Data/SqlClient/SNI/SNINpHandle.cs	68.85% <0.00%> (-9.84%)	⬇️
...ata/SqlClient/SqlConnectionTimeoutErrorInternal.cs	41.96% <0.00%> (-9.83%)	⬇️
...ActiveDirectoryAuthenticationTimeoutRetryHelper.cs	56.81% <0.00%> (-6.82%)	⬇️
...rc/Microsoft/Data/SqlClient/SQLFallbackDNSCache.cs	90.62% <0.00%> (-6.25%)	⬇️
.../src/Microsoft/Data/SqlClient/SNI/SNIMarsHandle.cs	87.89% <0.00%> (-4.49%)	⬇️
...Microsoft/Data/ProviderBase/DbConnectionFactory.cs	17.04% <0.00%> (-3.41%)	⬇️
...e/src/Microsoft/Data/SqlClient/SNI/SNITcpHandle.cs	60.62% <0.00%> (-2.34%)	⬇️
...Client/Reliability/Common/SqlRetryLogicProvider.cs	89.13% <0.00%> (-2.18%)	⬇️
...c/Microsoft/Data/SqlClient/SqlConnectionFactory.cs	68.85% <0.00%> (-0.82%)	⬇️
...rc/Microsoft/Data/ProviderBase/DbConnectionPool.cs	85.00% <0.00%> (-0.67%)	⬇️
... and 11 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e3aa5e...1bea873. Read the comment docs.

[JRahnama]

Closing this PR as it not in a mergeable state.