Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unknown transaction state issues when promoting delegated transaction #1216

Merged
merged 3 commits into from
Sep 20, 2021
Merged

Fix unknown transaction state issues when promoting delegated transaction #1216

merged 3 commits into from
Sep 20, 2021

Conversation

cheenamalhotra
Copy link
Member

Fixes #1163

@cheenamalhotra cheenamalhotra mentioned this pull request Aug 18, 2021
Closed
Kaur-Parminder added a commit to Kaur-Parminder/SqlClient that referenced this pull request Aug 23, 2021
@Kaur-Parminder
Fix unknown transaction state issues when promoting delegated transac…
ab024df 
…tion(Backport dotnet#1216)
DavoudEshtehari
DavoudEshtehari reviewed Aug 31, 2021
View reviewed changes
Copy link
Contributor

@DavoudEshtehari DavoudEshtehari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me, since the exception originally comes from System.Transaction.
Waiting for it to be verified by the bug reporter first.

@cheenamalhotra cheenamalhotra added this to the 4.0.0-preview2 milestone Aug 31, 2021
@cheenamalhotra cheenamalhotra mentioned this pull request Sep 1, 2021
Merged
@cheenamalhotra cheenamalhotra merged commit 186188d into dotnet:main Sep 20, 2021
@edwardneal edwardneal mentioned this pull request Sep 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavoudEshtehari DavoudEshtehari DavoudEshtehari left review comments

@ionmincu ionmincu ionmincu left review comments

@JRahnama JRahnama JRahnama approved these changes

@johnnypham johnnypham johnnypham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0-preview2
Development

Successfully merging this pull request may close these issues.

BUG: SqlDelegatedTransaction hides promoteException
5 participants
@cheenamalhotra @johnnypham @JRahnama @ionmincu @DavoudEshtehari