Update CannotCreateNormalize resource name in resource files #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavoudEshtehari
approved these changes
Jun 23, 2021
JRahnama
approved these changes
Jun 23, 2021
cheenamalhotra
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1041 I noticed a CI error https://github.com/dotnet/SqlClient/pull/1041/checks?check_run_id=2889045989 which indicates that a string resource can't be found. This is an update from #1057 which changed the name from
Sql_CanotCreateNormalizertoSQL_CannotCreateNormalizerbut these seem to have been reverted at some point since. This PR just makes sure the incorrect version no longer exists in the project.Can we get this reviewed and merged asap to prevent CI problems affecting other PRs? @cheenamalhotra