Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial logging changes #3087

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

deepchoudhery
Copy link
Member

@deepchoudhery deepchoudhery commented Nov 20, 2024

draft PR for now, want to get some feedback before adding support for trace logging, Serilog, file logging etc.

changes :

  • removed CleanConsoleFormatter, CleanConsoleFormatterOptions, ConsoleLoggerExtensions
  • added AnsiConsoleLogger and AnsiConsoleLoggerProvider
  • registering and using AnsiConsoleLoggerProvider in Builder\ScaffoldRunnerBuilder
  • AnsiConsoleLogger colorizes and prints to output. If we detect that the tool is being invoked by dotnet-scaffold we add the colorization tokens to the output but let dotnet-scaffold colorize it.

@deepchoudhery deepchoudhery self-assigned this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant