This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
Fix SpecialFolder.Personal usages #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpecialFolder Personal is the same value as MyDocuments, both of which will be changed on Unix from `~` to `~/Documents` in .NET 8. See dotnet/runtime#68610. Fixing the usage of SpecialFolder.Personal here to be UserProfile, since that's really what it wants.
jsuarezruiz
approved these changes
Sep 16, 2022
jsuarezruiz
reviewed
Oct 4, 2022
| @@ -36,7 +36,7 @@ item.XcodeSelect (); | |||
|
|
|||
| LogInstalledXcodes(); | |||
|
|
|||
| var appleSdkOverride = Path.Combine(Environment.GetFolderPath (Environment.SpecialFolder.Personal), "Library", "Preferences", "Xamarin", "Settings.plist"); | |||
| var appleSdkOverride = Path.Combine(Environment.GetFolderPath (Environment.SpecialFolder.UserProfile), "Library", "Preferences", "Xamarin", "Settings.plist"); | |||
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rmarinho
approved these changes
Oct 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpecialFolder Personal is the same value as MyDocuments, both of which will be changed on Unix from
~to~/Documentsin .NET 8. See dotnet/runtime#68610.Fixing the usage of SpecialFolder.Personal here to be UserProfile, since that's really what it wants.