#1612 fix wildcard topic subscription #1615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
chkr1011
requested changes
Dec 7, 2022
Source/MQTTnet/Server/Internal/MqttClientSubscriptionsManager.cs
Outdated
Show resolved
Hide resolved
chkr1011
merged commit afafdbb
into
dotnet:1612-mqttserver-subscription-to-similar-base-and-subtopic-with-wildcards-fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1612
There was an error in the early elimination of wildcard topics. It worked under the assumption that the same topic hash will have the same topic hash mask, which is not always the case for wildcard topics. This is fixed by storing wildcard subscriptions by topic hash mask and by comparing against the correct hash mask at the elimination stage. Unit test added also.