-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing several doc issues. #2835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maumar
force-pushed
the
doc_fixes
branch
2 times, most recently
from
November 6, 2020 07:42
2fe7ca2
to
08e43a1
Compare
maumar
commented
Nov 6, 2020
@@ -27,6 +27,8 @@ The following API and behavior changes have the potential to break existing appl | |||
| [Provider-specific EF.Functions methods throw for InMemory provider](#no-client-methods) | Low | | |||
| [IndexBuilder.HasName is now obsolete](#index-obsolete) | Low | | |||
| [A pluarlizer is now included for scaffolding reverse engineered models](#pluralizer) | Low | | |||
| [Some queries with correlated collection that also use Distinct or GroupBy are no longer supported](collection-distinct-groupby) | Low | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Medium?
Fix build warnings |
AndriySvyryd
reviewed
Nov 6, 2020
AndriySvyryd
reviewed
Nov 6, 2020
entity-framework/core/what-is-new/ef-core-5.0/breaking-changes.md
Outdated
Show resolved
Hide resolved
AndriySvyryd
reviewed
Nov 9, 2020
Did you run the images through something like Image Optimizer? |
updated and rebased @AndriySvyryd @bricelam |
bricelam
approved these changes
Nov 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #486
Fixes #756
Fixes #1311
Fixes #2307
Fixes #2511
Fixes #2731
Fixes #2823