Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some code snippets are still in-line #364

Closed
rowanmiller opened this issue Mar 9, 2017 · 3 comments
Closed

Some code snippets are still in-line #364

rowanmiller opened this issue Mar 9, 2017 · 3 comments
Labels
area-global closed-fixed good first issue This issue should be relatively straightforward to fix. punted-for-2.2
Milestone

Comments

@rowanmiller
Copy link
Contributor

When we migrated from ReadTheDocs, the automated migration turned all our linked source files to inline code listings. These should be turned back into links to the sample source code.

I've generally been fixing these as I've touched each file.

The old includes were using line numbers, so I've been converting them over to #regions while I go.

For example, after migration the md looks like this:

<!-- [!code-csharp[Main](samples/core/Querying/Querying/Basics/Sample.cs)] -->
````csharp
using (var context = new BloggingContext())
{
    var blogs = context.Blogs.ToList();
}

These need to be changed to:

[!code-csharp[Main](../../../samples/core/Querying/Querying/Basics/Sample.cs#RegionToInclude)]
@Rick-Anderson
Copy link
Contributor

@tdykstra we should add a list here of the tutorials that need this. We can split up the work.

@smitpatel
Copy link
Contributor

@Rick-Anderson - I was working on this recently. Having list of files to check would be useful but not necessary for me to work.

@Rick-Anderson
Copy link
Contributor

@smitpatel - Tom and I can do this. We'll ping you if we need coding help.

@smitpatel smitpatel removed their assignment Apr 8, 2017
@bricelam bricelam removed their assignment Apr 20, 2017
@divega divega modified the milestones: 2.0.0, 2.1.0 Dec 23, 2017
@divega divega added the good first issue This issue should be relatively straightforward to fix. label Feb 15, 2018
@tdykstra tdykstra removed their assignment Mar 5, 2018
@divega divega modified the milestones: 2.1.0, 2.2.0 Jul 10, 2018
@divega divega added the help wanted This issue involves technologies where we are not experts. Expert help would be appreciated. label Jul 31, 2018
@divega divega removed help wanted This issue involves technologies where we are not experts. Expert help would be appreciated. labels Nov 10, 2018
@divega divega modified the milestones: 2.2.0, 3.0.0 Feb 21, 2019
@ajcvickers ajcvickers removed this from the 3.0.0 milestone Aug 27, 2019
@ajcvickers ajcvickers added this to the Backlog milestone Aug 28, 2019
riccikl added a commit to riccikl/EntityFramework.Docs that referenced this issue Oct 19, 2019
riccikl added a commit to riccikl/EntityFramework.Docs that referenced this issue Oct 19, 2019
riccikl added a commit to riccikl/EntityFramework.Docs that referenced this issue Oct 26, 2019
@AndriySvyryd AndriySvyryd modified the milestones: Backlog, 3.1.0 Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-global closed-fixed good first issue This issue should be relatively straightforward to fix. punted-for-2.2
Projects
None yet
Development

No branches or pull requests

8 participants