Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add http custom headers #580

Merged

Conversation

HofmeisterAn
Copy link
Contributor

@galvesribeiro this allows the clients to set custom HTTP request headers. Depending on the API endpoint, this allows to enable or configure further features.

The first commit refactors some basics. It orders properties, methods, etc. by their modifier and applies ConfigureAwait to each await task.

The second commit adds the ability to set custom HTTP headers.

@HofmeisterAn HofmeisterAn force-pushed the feature/add-http-custom-headers branch from d5c1ac5 to beb931a Compare August 5, 2022 16:15
@HofmeisterAn
Copy link
Contributor Author

@galvesribeiro Can you take a look at this? Getting this feature merged would help us a lot.

@galvesribeiro galvesribeiro merged commit 6285c9a into dotnet:master Aug 17, 2022
@galvesribeiro
Copy link
Member

Ops, sorry, I've missed this. Thanks @HofmeisterAn !

@HofmeisterAn HofmeisterAn deleted the feature/add-http-custom-headers branch August 17, 2022 19:01
@HofmeisterAn
Copy link
Contributor Author

Ops, sorry, I've missed this. Thanks @HofmeisterAn !

No worries, thanks.

@BenasB
Copy link

BenasB commented Aug 24, 2022

Hi @galvesribeiro. I'm new to the project and just wanted to ask if there's any information about when this change will be released? I would like to use this, but unfortunately I can't reach the development package source from my corporate network.

@HofmeisterAn
Copy link
Contributor Author

@BenasB I think we can expect a new version with #579.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants