Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide more information in Desc structures #228

Merged
merged 2 commits into from
Aug 3, 2021

Conversation

andrew-boyarshin
Copy link
Contributor

@andrew-boyarshin andrew-boyarshin commented Apr 11, 2021

Some changes to provide more info to the IOutputBuilder and enable generating e.g. additional attributes to be parsed out later.

Drop the only use of OutputMode in PInvokeGenerator binding generation code. This is no place for hardcoding IOutputBuilder-specific logic.

Drop the only use of OutputMode in PInvokeGenerator binding generation
code. This is no place for hardcoding IOutputBuilder-specific logic.
@andrew-boyarshin andrew-boyarshin changed the title Upstream some more (WIP) Provide more information in Desc structures Apr 12, 2021
@andrew-boyarshin andrew-boyarshin marked this pull request as ready for review April 12, 2021 11:42
Copy link
Member

@Perksey Perksey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tysm for removing the hardcoded OutputMode! This was something that was added post-me that irked me a bit but apparently not enough to do anything about it...

@tannergooding
Copy link
Member

Sorry for the delay in getting this reviewed/merged.

Could you rebase or merge this with the latest main so we can get updated CI results?

@tannergooding tannergooding merged commit 6865a2f into dotnet:main Aug 3, 2021
@andrew-boyarshin andrew-boyarshin deleted the layout_desc branch August 4, 2021 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants