-
-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use .NET Standard 2.0 CommandLineParser, Update to net461 for NS2.0 support #992
Use .NET Standard 2.0 CommandLineParser, Update to net461 for NS2.0 support #992
Conversation
glennawatson
commented
Dec 24, 2018
- Added support for CommandLineParser 2.3.1 Net Standard 2.0 library -- this is for future work on support Xamarin releases
- Now use NET461 for the libraries, this is required for .Net Standard 2.0 support.
- Now use $(TargetFramework.StartsWith('net4')) in our csproj files, this allows upgrades to .NET 4 based libraries without the pain currently required.
Thanks for the PR! I am fine with moving from Could you please provide a link to the issue that we try to solve? I want to get more insight into it. I also want to switch from |
@adamsitnik you can't compile .net standard 2.0 libraries in your application with net46. See https://blogs.msdn.microsoft.com/dotnet/2017/08/14/announcing-net-standard-2-0/ So if you want to use either th command line parser ns2 or th command line API your going to hit the same wall you need to upgrade to net461 otherwise you'll get compile errors. |
commandlineparser/commandline#292 is the issue I am hitting. It's solved with commandlineparser/commandline#307 but again you can't get that fix without going to net461 due to it being the first version to support net standard 2.0. Net46 is not supported in that scenario |
Just as a note, CommandLineParser.NS20 was published by me some months ago to overcome the time till my PR is accepted. Unfortunately that still hasn't happened. |
@AndreyAkinshin are you ok with the update from .NET 4.6 to 4.6.1? I think that we will have to do it anyway since Roslyn's next version is going to support .NET Standard 2.0 only: https://www.nuget.org/packages/Microsoft.CodeAnalysis.CSharp/2.11.0-beta1-final (the lowest .NET supporting .NET Standard 2.0 is .NET 4.6.1) |
In general, I don't like the .NET 4.6->4.6.1 update. However, I understand that it will simplify future development a lot. Let's do it. In the future, we can introduce the |
@AndreyAkinshin @glennawatson thanks! |