-
-
Notifications
You must be signed in to change notification settings - Fork 970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ConfigOption for disabling the .NET SDK Validator #2641
Add ConfigOption for disabling the .NET SDK Validator #2641
Conversation
What's the actual error you're getting? I wonder if the validator can be fixed rather than disabled. |
In our specific case, we are passing in wasmnet90 but the SDK being installed is .NET 10 SDK. So it was invalid because there is no .NET 9 SDK installed, which is what we want at this point. Longer term we probably want to find a way to handle wasm that doesn't require us to have to specify the .NET version in the runtime. The error is "The required .NET Core SDK version 9.0 for runtime moniker WasmNet90 is not installed." |
Is running wasm for net9.0 supported with the net10 sdk?
Using BenchmarkDotNet/src/BenchmarkDotNet/ConsoleArguments/ConfigParser.cs Lines 550 to 551 in 3a2d115
|
Oh I see, you aren't using
Is that actually still relevant? Can that branch be removed and we just always use |
The .NET SDK can target previous versions, so it is fine to target 9 in a 10.0.xxx SDK, it is a required part of the support matrix. During the part of the year when the runtime and sdk are being updated to support a new tfm (now) that feature can be critical to resolve what would otherwise be circular dependencies between the runtime and sdk. |
So the Core SDK is backwards compatible just like the Framework SDK. In that case, we do need to update the validator to account for that backwards compatibility. We can also update the Either or both of those things should make this PR unnecessary, I think. |
Will close this PR in favour of an alternative solution |
We are in the process of upgrading the .NET runtime repository to target the .NET 10 TFM, and so when this happens we have some benchmarks which are configured to target .NET 9, but the .NET 10 SDK will be installed. We wanted to add a config option that lets us disable the SDK validator so that we can do this without getting a validation error.