Use "native" for .NET 8, don't use "serialize" for .NET 7 #2464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichalStrehovsky
approved these changes
Nov 14, 2023
| @@ -242,7 +256,7 @@ private static IEnumerable<string> GetCurrentProcessInstructionSets(Platform pla | |||
| if (HardwareIntrinsics.IsX86PclmulqdqSupported) yield return "pclmul"; | |||
| if (HardwareIntrinsics.IsX86PopcntSupported) yield return "popcnt"; | |||
| if (HardwareIntrinsics.IsX86AvxVnniSupported) yield return "avxvnni"; | |||
| if (HardwareIntrinsics.IsX86SerializeSupported) yield return "serialize"; | |||
| if (HardwareIntrinsics.IsX86SerializeSupported && runtimeMoniker > RuntimeMoniker.NativeAot70) yield return "serialize"; // https://github.com/dotnet/BenchmarkDotNet/issues/2463#issuecomment-1809625008 | |||
There was a problem hiding this comment.
This list is missing intrinsics added in .NET 8 but maybe that's not relevant if this is for 7 and below.
There was a problem hiding this comment.
Good point. But as you wrote, it's not relevant if we use "native" in .NET 8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use "native" for .NET 8, don't use "serialize" for .NET 7.
fixes #2060
fixes #2463
cc @MichalStrehovsky