don't place DynamicallyAccessedMembers on an array #1973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's a nop for NativeAOT and a bug for WASM
|
the fix has been verified by @radical : #1960 (comment) |
|
The new ( |
| @@ -12,6 +12,18 @@ public class GenericTypeArgumentsAttribute : Attribute | |||
| // CLS-Compliant Code requires a constructor without an array in the argument list | |||
There was a problem hiding this comment.
Nit: from the comment it looks like this constructor no longer needs to exist
adamsitnik
pushed a commit
to dotnet/performance
that referenced
this pull request
Mar 30, 2022
This was referenced Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's a nop for NativeAOT and a bug for WASM. Instead of using
paramsI've added ctors that accept 1, 2 and 3 types.#1960 (comment)
cc @MichalStrehovsky @radical