Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve local CoreCLR support #700

Closed
adamsitnik opened this issue Mar 22, 2018 · 5 comments
Closed

Improve local CoreCLR support #700

adamsitnik opened this issue Mar 22, 2018 · 5 comments
Assignees
@adamsitnik
Labels
Area:Toolchains
Milestone
v0.11.0

Comments

@adamsitnik
Copy link
Member

What we have today works, but is vulnerable to this problem

I want to use dotnet restore to install everything in a temp folder (not in the user/.nuget) to avoid this problem. But it takes a LOT of time so I need to implement #699 first.

Also part of the task is to verify that it works for all the OSes/
@adamsitnik adamsitnik added this to the v0.11.0 milestone Mar 22, 2018
@adamsitnik adamsitnik self-assigned this Mar 22, 2018
@AndreyAkinshin
Copy link
Member

Also part of the task is to verify that it works for all the OSes

@adamsitnik, what do you think, is it possible to write a test for it? I'm not sure that it should be one of our integration tests (because it takes to much time), but it would be nice to have an automatic way to test on any OS.

/cc @Ky7m

@adamsitnik
Copy link
Member Author

@AndreyAkinshin it's a great idea! I will implement such test and try it with our CI. If it takes too long (more than 5 minutes) I remove it.

@AndreyAkinshin
Copy link
Member

@adamsitnik, I think that we can introduce new project with integration tests which should be run manually.

@adamsitnik
Copy link
Member Author

@AndreyAkinshin another good idea!

@adamsitnik adamsitnik mentioned this issue Mar 26, 2018
Closed
adamsitnik added a commit that referenced this issue Mar 27, 2018
@adamsitnik
restore to a dedicated temp folder, rebuild only bare minumum, store …
c8a368a 
…everything in temp to avoid lock conflicts with VS, #700
adamsitnik added a commit that referenced this issue Mar 27, 2018
@adamsitnik
nice factory method for LocalCoreClr toolchain + removing filesToCopy…
63c9276 
… (won't be needed anymore), #700
adamsitnik added a commit that referenced this issue Mar 27, 2018
@adamsitnik
don't use isolated nuget packages folder for non-local feeds, #700
46ee627
adamsitnik added a commit that referenced this issue Mar 28, 2018
@adamsitnik
test nightly CoreFx builds support, #700, #702
d902e05
adamsitnik added a commit that referenced this issue Mar 28, 2018
@adamsitnik
use --no-dependencies first, if it fails run the full mode, #700 #702
11bfa74
adamsitnik added a commit that referenced this issue Mar 28, 2018
@adamsitnik
restore and build in explicit way, let publish just publish to hopefu…
6e379ca 
…lly make it work for AppVeyor, #700 #702
adamsitnik added a commit that referenced this issue Mar 29, 2018
@adamsitnik
/p:UseSharedCompilation=false by default to avoid zombie processes, r…
c99b47f 
…un Core tests first (more likely to fail), #700 #702
adamsitnik added a commit that referenced this issue Mar 29, 2018
@adamsitnik
introduce builder for CustomCoreClrToolchain to make it easier to con…
6f3d795 
…figure it, #700 #702
adamsitnik added a commit that referenced this issue Mar 30, 2018
@adamsitnik
print more diagnostic info, don't fail on first error and don't run t…
acca964 
…he tests in parallel #700
adamsitnik added a commit that referenced this issue Mar 30, 2018
@adamsitnik
just run the self contained app without dotnet host, #700 #702
0628e0e
adamsitnik added a commit that referenced this issue Apr 5, 2018
@adamsitnik
maing it work for Linux and Mac, #700, #702
b8217c3
adamsitnik added a commit that referenced this issue Apr 5, 2018
@adamsitnik
add test for local CoreCLR and CoreFX builds, move them to a new proj…
4b2f354 
…ect with can be run only manually, #700, #702
adamsitnik added a commit that referenced this issue Apr 5, 2018
@adamsitnik
allow to set RuntimeFrameworkVersion, #700 #702
b35e084
adamsitnik added a commit that referenced this issue Apr 5, 2018
@adamsitnik
the CanBenchmarkGivenCoreClrMyGetBuild should pass on Unix too, #700 #…
ca95871 
…702
adamsitnik added a commit that referenced this issue Apr 5, 2018
@adamsitnik
the docs for #700
9c4cbae
adamsitnik added a commit that referenced this issue Apr 5, 2018
@adamsitnik
Improved local CoreCLR/CoreFX support, tested on all OSes #700, #702
fcf6919 
This is a combination of 18 commits which I squashed, the most important were:
nice factory method for LocalCoreClr toolchain + removing filesToCopy (won't be needed anymore)
don't use isolated nuget packages folder for non-local feeds
update the tests projects to .NET Core 2.1
test nightly CoreFx builds support
use --no-dependencies first, if it fails run the full mode
restore and build in explicit way, let publish just publish
/p:UseSharedCompilation=false by default to avoid zombie processes, run Core tests first (more likely to fail)
remove old if defines that are no longer needed without .NET Core 1.1 support
introduce builder for CustomCoreClrToolchain to make it easier to configure it
print more diagnostic info, don't fail on first error and don't run the tests in parallel
just run the self contained app without dotnet host
add test for local CoreCLR and CoreFX builds, move them to a new project with can be run only manually
allow to set RuntimeFrameworkVersion
@adamsitnik
Copy link
Member Author

It took me a LOT of time to get it working and tested for ALL OSes, but it is finally done.

@adamsitnik adamsitnik mentioned this issue Apr 5, 2018
Closed
adamsitnik added a commit that referenced this issue Apr 6, 2018
@adamsitnik
allow the users to define an extra nuget feed, don't force clear tag …
7fbd6c8 
…for local builds (it would most probably fail for most of the users), #700 #702
This was referenced Apr 10, 2018
Closed
Merged
alinasmirnova pushed a commit to alinasmirnova/BenchmarkDotNet that referenced this issue Sep 22, 2018
@adamsitnik @alinasmirnova
restore to a dedicated temp folder, rebuild only bare minumum, store …
b521745 
…everything in temp to avoid lock conflicts with VS, dotnet#700
alinasmirnova pushed a commit to alinasmirnova/BenchmarkDotNet that referenced this issue Sep 22, 2018
@adamsitnik @alinasmirnova
Improved local CoreCLR/CoreFX support, tested on all OSes dotnet#700, d…
15235e8 
…otnet#702

This is a combination of 18 commits which I squashed, the most important were:
nice factory method for LocalCoreClr toolchain + removing filesToCopy (won't be needed anymore)
don't use isolated nuget packages folder for non-local feeds
update the tests projects to .NET Core 2.1
test nightly CoreFx builds support
use --no-dependencies first, if it fails run the full mode
restore and build in explicit way, let publish just publish
/p:UseSharedCompilation=false by default to avoid zombie processes, run Core tests first (more likely to fail)
remove old if defines that are no longer needed without .NET Core 1.1 support
introduce builder for CustomCoreClrToolchain to make it easier to configure it
print more diagnostic info, don't fail on first error and don't run the tests in parallel
just run the self contained app without dotnet host
add test for local CoreCLR and CoreFX builds, move them to a new project with can be run only manually
allow to set RuntimeFrameworkVersion
alinasmirnova pushed a commit to alinasmirnova/BenchmarkDotNet that referenced this issue Sep 22, 2018
@adamsitnik @alinasmirnova
allow the users to define an extra nuget feed, don't force clear tag …
d0a0288 
…for local builds (it would most probably fail for most of the users), dotnet#700 dotnet#702
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamsitnik adamsitnik

Labels
Area:Toolchains
Projects
None yet
Milestone
v0.11.0
Development

No branches or pull requests
2 participants
@AndreyAkinshin @adamsitnik