polishing the code, #699

src/BenchmarkDotNet/Environments/Runtime.cs

@@ -1,6 +1,8 @@
-namespace BenchmarkDotNet.Environments
+using System;
+
+namespace BenchmarkDotNet.Environments
 {
-    public abstract class Runtime
+    public abstract class Runtime : IEquatable<Runtime>
     {
         /// <summary>
         /// Full .NET Framework (Windows only)
@@ -21,12 +23,15 @@ public abstract class Runtime
 
         public string Name { get; }
 
-        protected Runtime(string name)
-        {
-            Name = name;
-        }
+        protected Runtime(string name) => Name = name;
 
         public override string ToString() => Name;
+
+        public bool Equals(Runtime other) => other != null && other.Name == Name; // for this type this is enough
+
+        public override bool Equals(object obj) => obj is Runtime other && Equals(other);
+
+        public override int GetHashCode() => Name.GetHashCode();
     }
 
     public class ClrRuntime : Runtime
@@ -43,17 +48,20 @@ public CoreRuntime() : base("Core")
         }
     }
 
-    public class MonoRuntime : Runtime
+    public class MonoRuntime : Runtime, IEquatable<MonoRuntime>
     {
         public string CustomPath { get; }
 
         public MonoRuntime() : base("Mono")
         {
         }
 
-        public MonoRuntime(string name, string customPath) : base(name)
-        {
-            CustomPath = customPath;
-        }
+        public MonoRuntime(string name, string customPath) : base(name) => CustomPath = customPath;
+
+        public override bool Equals(object obj) => obj is MonoRuntime other && Equals(other);
+
+        public bool Equals(MonoRuntime other) => other != null && Name == other.Name && CustomPath == other.CustomPath;
+
+        public override int GetHashCode() => Name.GetHashCode() ^ (CustomPath?.GetHashCode() ?? 0);
     }
 }

src/BenchmarkDotNet/Running/BuildPartition.cs

@@ -1,10 +1,8 @@
 using System;
-using System.Linq;
 using BenchmarkDotNet.Characteristics;
 using BenchmarkDotNet.Environments;
 using BenchmarkDotNet.Jobs;
 using BenchmarkDotNet.Portability;
-using BenchmarkDotNet.Toolchains;
 
 namespace BenchmarkDotNet.Running
 {
@@ -13,9 +11,9 @@ public class BuildPartition
         public BuildPartition(BenchmarkBuildInfo[] benchmarks, IResolver resolver)
         {
             Resolver = resolver;
-            RepresentativeBenchmark = benchmarks.Select(info => info.Benchmark).FirstOrDefault();
+            RepresentativeBenchmark = benchmarks[0].Benchmark;
             Benchmarks = benchmarks;
-            ProgramName = Guid.NewGuid().ToString(); // todo: figure out some nice name (first job.Folder?)
+            ProgramName = benchmarks[0].Config.KeepBenchmarkFiles ? RepresentativeBenchmark.Job.FolderInfo : Guid.NewGuid().ToString();
         }
 
         public BenchmarkBuildInfo[] Benchmarks { get; }
@@ -24,7 +22,7 @@ public BuildPartition(BenchmarkBuildInfo[] benchmarks, IResolver resolver)
 
         /// <summary>
         /// the benchmarks are groupped by the build settings
-        /// so you can use this benchmark to get the settings
+        /// so you can use this benchmark to get the runtime settings
         /// </summary>
         public Benchmark RepresentativeBenchmark { get; }
 
@@ -42,6 +40,6 @@ public BuildPartition(BenchmarkBuildInfo[] benchmarks, IResolver resolver)
                 ? RepresentativeBenchmark.Job.Env.Runtime
                 : RuntimeInformation.GetCurrentRuntime();
 
-        public override string ToString() => $"{Runtime}-{Platform}-{Jit}-{RepresentativeBenchmark.Job.GetToolchain()}";
+        public override string ToString() => RepresentativeBenchmark.Job.DisplayInfo;
     }
 }

src/BenchmarkDotNet/Toolchains/Parameters/ExecuteParameters.cs

@@ -9,8 +9,7 @@ namespace BenchmarkDotNet.Toolchains.Parameters
 {
     public class ExecuteParameters
     {
-        public ExecuteParameters(BuildResult buildResult, Benchmark benchmark, BenchmarkId benchmarkId, ILogger logger, IResolver resolver, IConfig config,
-            IDiagnoser diagnoser = null)
+        public ExecuteParameters(BuildResult buildResult, Benchmark benchmark, BenchmarkId benchmarkId, ILogger logger, IResolver resolver, IConfig config, IDiagnoser diagnoser = null)
         {
             BuildResult = buildResult;
             Benchmark = benchmark;