-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix typo in directory name #30498
fix typo in directory name #30498
Conversation
@tdykstra had the same comment, I'm not seeing that. https://learn.microsoft.com/en-us/aspnet/core/fundamentals/aot/request-delegate-generator/diagnostics/rdg002?view=aspnetcore-8.0 is rendering correctly and you version isn't finding the snippets. |
The reason why it's rendered correctly on the live learn website is because the samples are added to the directory containing the typo (diagonstics). The current state of this PR fails because it cannot find the snippets due to the rename within the docs, but not in the samples repo. To fix the build (at least how I see it, and feel free to correct me), I think the PR of the samples repo needs be merged first (dotnet/AspNetCore.Docs.Samples#192) because it fixes the typo within that repo. After the samples PR is merged this PR will successfully build because it can now find the files. I tested this on my local machine (it works on my machine 😅) |
@timdeschryver can you change all the |
Actually, it's a file rename that needs to happen, drop the d in the file name |
Sorry, I was just leaving. Thanks for the fixup! |
Thanks for fixing this. @tdykstra notified me of the same problem and I couldn't see it, ha. |
Coming from #27865 (comment)
This PR fixes a typo in the directory name (diagonstics => diagnostics).
After this PR, the "base" is good to pick up the other issues without interrupting each other.
Should be merged together with dotnet/AspNetCore.Docs.Samples#192
Internal previews