Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blazor Hybrid routing and nav topic #25130

Merged
merged 4 commits into from
Feb 24, 2022
Merged

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Feb 24, 2022

Addresses #24956

Internal Review Topic

Notes

  • These will be rough at first. I'll circle around later for niceties like API doc cross-links (when available), enhanced descriptions, fully-working, cut-'n-paste code examples, etc.
  • Although this PR doesn't include routing coverage, I think we'll probably be adding at least a brief remark that component routing (in a BlazorWebView) conforms to the coverage in the Blazor Fundamentals node topic on the subject with any caveats or gotchas 😈 that you want to call out. Fundamentals topic on routing/nav ... Does it all apply to Hybrid scenarios (BlazorWebView)?

@guardrex guardrex mentioned this pull request Feb 24, 2022
25 tasks
@TanayParikh
Copy link
Contributor

TanayParikh commented Feb 24, 2022

Thanks @guardrex. I'm going to hold off on reviewing till the original PR is merged, just in case there are minor changes like renaming the enum value.

cross linking dotnet/maui#4645

Copy link
Contributor

@TanayParikh TanayParikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than one minor formatting change. Thanks!

aspnetcore/blazor/hybrid/routing.md Outdated Show resolved Hide resolved
@guardrex guardrex merged commit 92a6569 into main Feb 24, 2022
@guardrex guardrex deleted the guardrex/blazor-hybrid-navigation branch February 24, 2022 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants