Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dotnet-watch tutorial #1515

Merged
merged 2 commits into from
Jun 28, 2016
Merged

dotnet-watch tutorial #1515

merged 2 commits into from
Jun 28, 2016

Conversation

victorhurdugaci
Copy link
Contributor

Fixes #696

A tutorial on using dotnet watch

Please review @Rick-Anderson @rachelappel @danroth27

@dnfclas
Copy link

dnfclas commented Jun 24, 2016

Hi @victorhurdugaci, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

BrennanConroy
BrennanConroy reviewed Jun 24, 2016
View reviewed changes
aspnet/tutorials/dotnet-watch.rst
@@ -0,0 +1,198 @@
.. _dotnet-watch:

Developing ASP.NET applications using dotnet watch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ASP.NET Core

@victorhurdugaci victorhurdugaci mentioned this pull request Jun 24, 2016
Merged
cesarblum
cesarblum reviewed Jun 24, 2016
View reviewed changes
aspnet/tutorials/dotnet-watch.rst

.. code-block:: bash

user$ dotnet run
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove user and leave it just as $.

@Rick-Anderson
Copy link
Contributor

@victorhurdugaci really excellent! Let me know when you're finished or if you need anything from me.

BrennanConroy
BrennanConroy reviewed Jun 25, 2016
View reviewed changes
aspnet/tutorials/dotnet-watch.rst
Application started. Press Ctrl+C to shut down.

Making changes with ``dotnet watch``
------------------------------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you are starting another section, you should say something about "make sure you have dotnet watch running on the WebApp"

@victorhurdugaci
Copy link
Contributor Author

victorhurdugaci commented Jun 27, 2016 •
edited
Loading

Updated.

@Rick-Anderson any more comments? Also, should it be merged in master? Do I merge it or will you do it?

@Rick-Anderson
Copy link
Contributor

looks good. :shipit:

@Rick-Anderson Rick-Anderson merged commit f1603d2 into dev Jun 28, 2016
@Rick-Anderson Rick-Anderson deleted the victorhu/dotnet-watch branch June 28, 2016 03:32
@Rick-Anderson
Copy link
Contributor

@rachelappel can you get this migrated to master? cc @victorhurdugaci this is not showing up in master.

@rachelappel
Copy link
Contributor

Merged 7597448

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@victorhurdugaci @dnfclas @Rick-Anderson @rachelappel @cesarblum @BrennanConroy