Skip to content
This repository has been archived by the owner on Jun 29, 2020. It is now read-only.

Add PostgreSQL health check #10

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

lurumad
Copy link

@lurumad lurumad commented Mar 21, 2017

I've added a health check for PostgreSQL.

Cheers!!!

@alistair
Copy link

This would be super useful but at the moment I have a concern with this approach. This adds a dependency on npgsql for all users of the data library, whether they are using it or not. This would only get worse if you add all the other databases in there as well.

Maybe healthcheck.Data should only use DbConnection and provide an method which allows a user to pass in that connection. Then the postgres, sqlserver, mysql extension methods can be implemented either in seperate packages and just leverages that.

@damienbod
Copy link

I think extension packages like the loggers do it would be a better solution.

@lurumad
Copy link
Author

lurumad commented Mar 21, 2017

Yes, you are right!

But, Microsoft.Extensions.HealthChecks.Data could be a Nuget package also?

Cheers!

@damienbod
Copy link

sounds good to me, I created a seperate issue about the extension idea.
#14

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants