Feature/dot 354 design and implement offline component #826
+152
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of https://github.com/dotkom/monoweb into feature/dot-354-design-and-implement-offline-component
…n-and-implement-offline-component
…/dot-354-design-and-implement-offline-component
hanlun0804
assigned hanlun0804 and henrikhorluck and unassigned hanlun0804 and henrikhorluck
There was a problem hiding this comment.
I think that as a reviewer I should not have to write any code, could you please either add the component somewhere it is used, or make it available to see somewhere else?
For example: this could be moved to the ui-package so that it is shown in ladle (localhost:61000), and it should ideally have some data-fixtures available to check it working
@junlarsen probably has better control of where to place this
Also: this branch should be updated with latest main, ideally with a rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an offline component for monoweb's homepage.
Closes: #...
Checklist
Changelog
How to test
Place component a convenient place in monoweb and use an array of links to images as parameters. Pass this as both "images" and "pdfs". Component will use an array of links to the frontpage as images and an array of links to the pdfs in the future, when these are possible to access.