apollo-usage-report - get missing operationName from the OperationDefinitionNode #3488
Conversation
🦋 Changeset detectedLatest commit: 896bea9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@EmrysMyrddin or @ardatan 🙏 |
| @@ -271,3 +297,14 @@ async function sendTrace( | |||
| logger.error('Failed to send trace:', err); | |||
| } | |||
| } | |||
|
|
|||
| function isDocumentNode(data: unknown): data is DocumentNode { | |||
| const isObject = (data: unknown): data is Record<string, unknown> => | |||
There was a problem hiding this comment.
Not sure this has to be inlined into the isDocument function ? It's not using any variable from the scope.
|
|
||
| function isDocumentNode(data: unknown): data is DocumentNode { | ||
| const isObject = (data: unknown): data is Record<string, unknown> => | ||
| Object.prototype.toString.call(data).slice(8, -1) === 'Object'; |
There was a problem hiding this comment.
Is there a reason to use this trick instead of typeof data === "object" ?
There was a problem hiding this comment.
I agree that deriving the operation name from the query document is a good idea.
If it's needed, I don't see anything the prevent us to move the whole logic to the onParse hook.
Because in the current implementation of the PR, the signature will be computed twice for each query without operation name, which can be expansive for huge queries.
Description
If someone send GraphQL query without
operationNamein request body, we should try to get it from theOperationDefinitionNodeafter the query parsing is finished.I added this logic to the
onParse(onParseEnd) handler, but I'm not sure if all the logic of theonEnvelopedhandler should be moved to theonParseEndhandler?operationNameis missing if someone send request with body{ "query": "query TestQueryName{me{userAccount{id loginName}}}" }and the result in Apollo Studio metrics is: ❌
{ "query": "query TestQueryName{me{userAccount{id loginName}}}", "operationName": "TestQueryName" }the result in Apollo Studio metrics is: ✅
