Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow providing a buffer for pubsub subscribe call #3440

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

n1ru4l
Copy link
Collaborator

@n1ru4l n1ru4l commented Oct 3, 2024

As requested via #3409

Copy link

changeset-bot bot commented Oct 3, 2024

🦋 Changeset detected

Latest commit: b5c4265

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 25 packages
Name Type
@graphql-yoga/subscription Minor
graphql-yoga Patch
@graphql-yoga/nestjs Patch
@graphql-yoga/render-graphiql Patch
@graphql-yoga/plugin-apollo-inline-trace Patch
@graphql-yoga/apollo-managed-federation Patch
@graphql-yoga/plugin-apollo-usage-report Patch
@graphql-yoga/plugin-apq Patch
@graphql-yoga/plugin-csrf-prevention Patch
@graphql-yoga/plugin-defer-stream Patch
@graphql-yoga/plugin-disable-introspection Patch
@graphql-yoga/plugin-graphql-sse Patch
@graphql-yoga/plugin-jwt Patch
@graphql-yoga/plugin-persisted-operations Patch
@graphql-yoga/plugin-prometheus Patch
@graphql-yoga/plugin-response-cache Patch
@graphql-yoga/plugin-sofa Patch
apollo-federation-gateway-with-yoga Patch
apollo-subgraph-with-yoga Patch
graphql-lambda Patch
cloudflare-advanced Patch
cloudflare Patch
nextjs-app Patch
hello-world-benchmark Patch
@graphql-yoga/nestjs-federation Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 3, 2024

💻 Website Preview

The latest changes are available as preview in: https://12818ade.graphql-yoga.pages.dev

Copy link
Contributor

github-actions bot commented Oct 3, 2024

✅ Benchmark Results

     ✓ no_errors{mode:graphql}
     ✓ expected_result{mode:graphql}
     ✓ no_errors{mode:graphql-jit}
     ✓ expected_result{mode:graphql-jit}
     ✓ no_errors{mode:graphql-response-cache}
     ✓ expected_result{mode:graphql-response-cache}
     ✓ no_errors{mode:graphql-no-parse-validate-cache}
     ✓ expected_result{mode:graphql-no-parse-validate-cache}

     checks.......................................: 100.00% ✓ 410184      ✗ 0     
     data_received................................: 1.7 GB  14 MB/s
     data_sent....................................: 83 MB   690 kB/s
     http_req_blocked.............................: avg=1.55µs   min=1.02µs   med=1.35µs   max=243.01µs p(90)=2.03µs   p(95)=2.21µs  
     http_req_connecting..........................: avg=2ns      min=0s       med=0s       max=142.13µs p(90)=0s       p(95)=0s      
     http_req_duration............................: avg=365.96µs min=219.2µs  med=329.96µs max=23.31ms  p(90)=474.91µs p(95)=494.81µs
       { expected_response:true }.................: avg=365.96µs min=219.2µs  med=329.96µs max=23.31ms  p(90)=474.91µs p(95)=494.81µs
     ✓ { mode:graphql-jit }.......................: avg=290.08µs min=219.2µs  med=273.41µs max=23.31ms  p(90)=305.93µs p(95)=322.92µs
     ✓ { mode:graphql-no-parse-validate-cache }...: avg=495.13µs min=401.68µs med=469.83µs max=7.62ms   p(90)=509.53µs p(95)=552.42µs
     ✓ { mode:graphql-response-cache }............: avg=345.48µs min=269.36µs med=327.19µs max=9.44ms   p(90)=358.04µs p(95)=370.29µs
     ✓ { mode:graphql }...........................: avg=369.25µs min=281.56µs med=340.49µs max=13.57ms  p(90)=399.87µs p(95)=452.48µs
     http_req_failed..............................: 0.00%   ✓ 0           ✗ 205092
     http_req_receiving...........................: avg=33.71µs  min=17.89µs  med=33.2µs   max=2.6ms    p(90)=40.16µs  p(95)=42.9µs  
     http_req_sending.............................: avg=8.73µs   min=6.06µs   med=7.62µs   max=1.06ms   p(90)=11.16µs  p(95)=12.22µs 
     http_req_tls_handshaking.....................: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting.............................: avg=323.5µs  min=187.04µs med=288.18µs max=23.14ms  p(90)=431.86µs p(95)=450.45µs
     http_reqs....................................: 205092  1709.076029/s
     iteration_duration...........................: avg=580.02µs min=383.99µs med=539.6µs  max=23.83ms  p(90)=692.08µs p(95)=716.7µs 
     iterations...................................: 205092  1709.076029/s
     vus..........................................: 1       min=1         max=1   
     vus_max......................................: 2       min=2         max=2   

Copy link
Contributor

github-actions bot commented Oct 3, 2024

Apollo Federation Subgraph Compatibility Results

Federation 1 Support Federation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🟢
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

...[routingKey, id]: TPubSubPublishArgsByKey[TKey][1] extends undefined
? [TKey]
: [TKey, TPubSubPublishArgsByKey[TKey][0]]
...args:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fun

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fun or breaking change 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants