Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fulfill aws-lambda peerDependency. #115

Merged
merged 1 commit into from
Feb 15, 2018
Merged

Fulfill aws-lambda peerDependency. #115

merged 1 commit into from
Feb 15, 2018

Conversation

wtgtybhertgeghgtwtg
Copy link
Contributor

graphql-playground-middleware-lambda complains if aws-lambda isn't around. I don't think Lamda stuff should have been added here in the first place, but at the very least the user shouldn't be getting warnings.

Copy link
Contributor

@kbrandwijk kbrandwijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this lambda stuff shouldn't be added here like this. That also means I don't agree with adding it.

@wtgtybhertgeghgtwtg
Copy link
Contributor Author

graphql-playground-middleware-lambda does not work if aws-lambda is missing. Doesn't this mean that AWS support doesn't work out of the box?

@schickling
Copy link
Contributor

I agree with @wtgtybhertgeghgtwtg here. @wtgtybhertgeghgtwtg can you rebase the branch so we can merge?

@wtgtybhertgeghgtwtg
Copy link
Contributor Author

I have rebased the branch.

@schickling schickling merged commit cb07c98 into dotansimha:master Feb 15, 2018
@wtgtybhertgeghgtwtg wtgtybhertgeghgtwtg deleted the add-aws-lambda branch February 15, 2018 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants