Fix duplicate indentifiers in import statements #4186
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #3990
I had a look into issue #3990 as I was experiencing the same symptoms, the fix proposed in this comment did not work for me as the imports are generated in the
visitor-plugin-common
package.In my case it seemed like duplicate fragment identifiers were only generated sometimes, for example I would get something like the below in my generated files (unfortunately it's an internal codebase that I'm not able to share - I believe this comment references a codebase that can reproduce the bug):
This change deduplicates the list of import identifiers prior to being joined in the import statement. After making the change I get the expected, valid import statement generated.