Improve performance by not building schema AST over and over #2073
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each plugin being executed was generating an AST of the schema over and over again, which was especially painful when using
near-operations-file
.With this change the AST is built early, and only rebuilt in situations where it isn't passed to the plugin for whatever reason, or a plugin changes the schema.
In my project it decreased execution time from 10s to 4s (250%)
Before
After
There's probably still more that could be done, but this takes care of the worst bits
Addresses the performance issues mentioned on #2069