Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: fixed bug with useFlowReadOnlyTypes on Enums #1413

Merged
merged 1 commit into from
Mar 6, 2019
Merged

FIX: fixed bug with useFlowReadOnlyTypes on Enums #1413

merged 1 commit into from
Mar 6, 2019

Conversation

zanettin
Copy link
Contributor

@zanettin zanettin commented Mar 6, 2019

just fixing a bug which occurred after introducing useFlowReadOnlyTypes on handling Enums.

current output

export const MyEnumValues = Object.freeze({
  +A: 'A',
  +B: 'B',
  +C: 'C'
});

fixed output

export const MyEnumValues = Object.freeze({
  A: 'A',
  B: 'B',
  C: 'C'
});

@dotansimha
Copy link
Owner

dotansimha commented Mar 6, 2019

Nice, I'm merging, but I'll need to reimplement it here again: #1353, because TypeScript plugins and Flow plugins have common logic now, and we refactored them.
Thanks @zanettin !

@dotansimha dotansimha mentioned this pull request Mar 6, 2019
38 tasks
@zanettin
Copy link
Contributor Author

zanettin commented Mar 6, 2019

thanks a lot @dotansimha 🎉

@dotansimha dotansimha merged commit 893af3b into dotansimha:master Mar 6, 2019
dotansimha added a commit that referenced this pull request Mar 6, 2019
Make sure bug with useFlowReadOnlyTypes on Enums is fixed #1413
kamilkisiela pushed a commit that referenced this pull request Mar 14, 2019
Related: #1350 

Planned in this PR:
- [x] Move all common code from `flow` to a common package.
- [x] Make sure `flow` plugin works.
- [x] Add the latest changes of `flow` plugin.
- [x] Create `typescript` package with the same features as `flow` package.
- [x] Write tests for `typescript` package.
 
- [x] Move all common code from `flow-documents` to a common package.
- [x] Make sure `flow-documents` plugin works.
- [x] Add the latest changes of `flow-documents` plugin.
- [x] Create `typescript-documents` package with the same features as `flow-documents` package.
- [x] Write tests for `typescript-documents` package.
- [x] Move all common code from `flow-resolvers` to a common package.
- [x] Make sure `flow-resolvers` plugin works.
- [x] Add the latest changes of `flow-resolvers` plugin.
- [x] Create `typescript-resolvers` package with the same features as `flow-resolvers` package.
- [x] Write tests for `typescript-resolvers` package.
- [x] Add missing features from previous `typescript` package.
- [x] Add missing features from previous `typescript-documents` package.
- [x] Add missing features from previous `typescript-resolvers` package.
- [x] Add introspection types @kamilkisiela  #1406
- [x] Implement `namingConvention` again @kamilkisiela  #1407
- [x] Fix issue with prefix @kamilkisiela #1407
- [x] Apply this: #1357 @ardatan 
- [x] Refactor `react-apollo` @dotansimha 
- [x] Refactor `apollo-angular` @dotansimha 
- [x] Apply fix to Flow plugins: #1413 @kamilkisiela 
- [x] Refactor `typescript-mongo` @dotansimha  
- [x] Refactor `stencil-apollo` @ardatan
- [x] Remove Handlebars compiler package from all plugins, and add support for tree shaking. @ardatan 
- [x] Make sure to update packages in `gql-gen init`  @kamilkisiela 
- [x] Rename `XXX-documents` to `XXX-operations`
- [x] Move all flatten utils from `core` to `plugin-helpers` and clean `core` package. @kamilkisiela 
- [x] Deprecate `buildTemplateContext` and `flattenTypes`. @kamilkisiela 
- [x] Repo cleanup
- [x] Update README @kamilkisiela  
- [x] Update docs @kamilkisiela  
- [x] Write docs about writing plugins with visitor @kamilkisiela 
- [x] Update examples
- [x] Change packages names @dotansimha
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants