typescript-client: Include __typename in fragments and metadata fields #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know if that works within fragments but I think it's enough for now |
|
Awesome! ❤️ @kamilkisiela |
|
@dotansimha ❤️ of course! |
kamilkisiela
added a commit
that referenced
this pull request
Mar 1, 2019
dotansimha
pushed a commit
that referenced
this pull request
Mar 4, 2019
dotansimha
pushed a commit
that referenced
this pull request
Mar 5, 2019
dotansimha
pushed a commit
that referenced
this pull request
Mar 6, 2019
|
@kamilkisiela thanks for the work, this helped me quite a bit Are you planning on adding |
|
Playing with the canary build, I guess my true ask would be to (optionally?) add |
dotansimha
pushed a commit
that referenced
this pull request
Mar 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixesss (@dotansimha
related) #643 (comment) and #643 (comment)