change valueOfLabel to valueOf for enum, fix #6320 (#6323)

dotansimha · Aug 3, 2021 · 1da66a6 · 1da66a6
1 parent a89b85a
commit 1da66a6
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/.changeset/metal-students-pump.md b/.changeset/metal-students-pump.md
@@ -0,0 +1,5 @@
+---
+'@graphql-codegen/java': minor
+---
+
+revert removal of `valueOfLabel` in Enum generation
diff --git a/packages/plugins/java/java/src/visitor.ts b/packages/plugins/java/java/src/visitor.ts
@@ -217,7 +217,7 @@ export class JavaResolversVisitor extends BaseVisitor<JavaResolversPluginRawConf
             `if (args.get("${arg.name.value}") instanceof ${typeToUse.typeName}) {
   this.${this.config.classMembersPrefix}${arg.name.value} = (${typeToUse.typeName}) args.get("${arg.name.value}");
 } else {
-  this.${this.config.classMembersPrefix}${arg.name.value} = ${typeToUse.typeName}.valueOfLabel((String) args.get("${arg.name.value}"));
+  this.${this.config.classMembersPrefix}${arg.name.value} = ${typeToUse.typeName}.valueOf((String) args.get("${arg.name.value}"));
 }`,
             3
           );

diff --git a/packages/plugins/java/java/tests/java.spec.ts b/packages/plugins/java/java/tests/java.spec.ts
@@ -237,7 +237,7 @@ describe('Java', () => {
       expect(result).toBeSimilarStringTo(`if (args.get("sort") instanceof ResultSort) {
         this.sort = (ResultSort) args.get("sort");
       } else {
-        this.sort = ResultSort.valueOfLabel((String) args.get("sort"));
+        this.sort = ResultSort.valueOf((String) args.get("sort"));
       }`);
     });
 
@@ -274,7 +274,7 @@ describe('Java', () => {
             if (args.get("sort") instanceof ResultSort) {
               this.sort = (ResultSort) args.get("sort");
             } else {
-              this.sort = ResultSort.valueOfLabel((String) args.get("sort"));
+              this.sort = ResultSort.valueOf((String) args.get("sort"));
             }
             this.metadata = new MetadataSearchInput((Map<String, Object>) args.get("metadata"));
           }
@@ -407,7 +407,7 @@ describe('Java', () => {
     //   expect(result).toBeSimilarStringTo(`if (args.get("sort") instanceof ResultSort) {
     //     this.sort = (ResultSort) args.get("sort");
     //   } else {
-    //     this.sort = ResultSort.valueOfLabel((String) args.get("sort"));
+    //     this.sort = ResultSort.valueOf((String) args.get("sort"));
     //   }`);
     // });