Skip to content

Commit

Permalink
Fix Analyzer build warnings when turning on `EnforceExtendedAnalyzerR…
Browse files Browse the repository at this point in the history
…ules`
  • Loading branch information
Morten Nielsen committed Feb 21, 2024
1 parent fc7dd3b commit 7a19ee0
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 4 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
## Release 1.0

### New Rules

Rule ID | Category | Severity | Notes
--------|----------|----------|--------------------
WinUIEx1001 | Usage | Warning | The member will always be null, [Documentation](https://dotmorten.github.io/WinUIEx/rules/WinUIEx1001.html)
WinUIEx1002 | Usage | Warning | Dispatcher must be replaced with DispatcherQueue, [Documentation](https://dotmorten.github.io/WinUIEx/rules/WinUIEx1002.html)
4 changes: 2 additions & 2 deletions src/WinUIEx.Analyzers/WinUIEx.Analyzers/Resources.Designer.cs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/WinUIEx.Analyzers/WinUIEx.Analyzers/Resources.resx
Original file line number Diff line number Diff line change
Expand Up @@ -121,10 +121,10 @@
<value>The member was never implemeted in WinUI 3.</value>
</data>
<data name="AlwaysNullMessageFormat" xml:space="preserve">
<value>The member '{0}' will always be null and should not be used.</value>
<value>The member '{0}' will always be null and should not be used</value>
</data>
<data name="AlwaysNullTitle" xml:space="preserve">
<value>The member will always be null.</value>
<value>The member will always be null</value>
</data>
<data name="DispatcherDescription" xml:space="preserve">
<value>The Dispatcher will always return null. It has been replaced by the DispatcherQueue.</value>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

<!-- Avoid ID conflicts with the package project. -->
<PackageId>*$(MSBuildProjectFile)*</PackageId>
<EnforceExtendedAnalyzerRules>true</EnforceExtendedAnalyzerRules>
</PropertyGroup>

<ItemGroup>
Expand All @@ -19,6 +20,7 @@
<ItemGroup>
<Compile Update="Resources.Designer.cs" DesignTime="True" AutoGen="True" DependentUpon="Resources.resx" />
<EmbeddedResource Update="Resources.resx" Generator="ResXFileCodeGenerator" LastGenOutput="Resources.Designer.cs" />
<AdditionalFiles Include="AnalyzerReleases.Shipped.md" />
</ItemGroup>

</Project>

0 comments on commit 7a19ee0

Please sign in to comment.