-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Microsoft.Data.SqlClient 2.1.0 #58
Conversation
@ErikEJ what do you mean? |
Signing: you had signing enabled at some point, but then removed it soon after... Unsure why. |
src/Microsoft.SqlServer.Types.M.D.S/Microsoft.SqlServer.Types.M.D.S.csproj
Outdated
Show resolved
Hide resolved
I digitally sign the nuget packages locally at a later stage before publishing. I never did this here. |
Sorry, I mean strong naming!! |
Aaah good call. Didn't even notice that went away |
I think it may be worth keeping it to improve the user experience (as far as I can tell from discussions in various GitHub issues) |
Should I add it back to the original project? |
Left strong naming enabled in the new project, should I also add it back to the original, or remove it altogether? |
Let me know if more changes are needed. |
@dotMorten Anything I can do to help get this in? |
@ErikEJ since it looks like this is not moving forward, I've published a version using It's not based in your code (no |
fixes #51
fixes #29
Design decisions: