Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Microsoft.Data.SqlClient 2.1.0 #58

Closed
wants to merge 4 commits into from

Conversation

ErikEJ
Copy link

@ErikEJ ErikEJ commented Dec 12, 2020

fixes #51
fixes #29

Design decisions:

  • Name of package ?
  • Use of strong naming (unclear why this was removed from the original package) ?

@dotMorten
Copy link
Owner

Use of signing (unclear why this was removed from the original package) ?

@ErikEJ what do you mean?

@ErikEJ
Copy link
Author

ErikEJ commented Dec 12, 2020

Signing: you had signing enabled at some point, but then removed it soon after... Unsure why.

@dotMorten
Copy link
Owner

dotMorten commented Dec 12, 2020

Signing: you had signing enabled at some point, but then removed it soon after... Unsure why.

I digitally sign the nuget packages locally at a later stage before publishing. I never did this here.

@ErikEJ
Copy link
Author

ErikEJ commented Dec 12, 2020

Sorry, I mean strong naming!!

@dotMorten
Copy link
Owner

Aaah good call. Didn't even notice that went away

@ErikEJ
Copy link
Author

ErikEJ commented Dec 12, 2020

I think it may be worth keeping it to improve the user experience (as far as I can tell from discussions in various GitHub issues)

@ErikEJ
Copy link
Author

ErikEJ commented Dec 12, 2020

Should I add it back to the original project?

@ErikEJ ErikEJ marked this pull request as ready for review December 13, 2020 07:42
@ErikEJ ErikEJ changed the title Add new package that use Microsoft.Data.SqlClient 2.1.0 Use Microsoft.Data.SqlClient 2.1.0 Dec 13, 2020
@ErikEJ
Copy link
Author

ErikEJ commented Dec 13, 2020

Left strong naming enabled in the new project, should I also add it back to the original, or remove it altogether?

@ErikEJ
Copy link
Author

ErikEJ commented Jan 3, 2021

Let me know if more changes are needed.
😄

@ErikEJ
Copy link
Author

ErikEJ commented Aug 3, 2021

@dotMorten Anything I can do to help get this in?

@olmobrutall
Copy link
Contributor

@ErikEJ since it looks like this is not moving forward, I've published a version using Microsoft.Data.SqlClient instead of System.Data.SqlClient in https://www.nuget.org/packages/Unofficial.Microsoft.SqlServer.Types

It's not based in your code (no #if NETCOREAPP3_1, just a hard change) but most of the changes are similar (removing namespaces etc..)

@ErikEJ ErikEJ closed this Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants