Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix on OpenCore (GPRW to XPRW) #128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

TonyOps
Copy link

@TonyOps TonyOps commented Mar 3, 2023

This fix is intended to correct the GPRW to XPRW patch, as it contains a certain error that presents invalid characters at the end, making the purpose of the patch inaccessible. In the original, at the end of each code (47505257 and 58505257, respectively), there is the number 02. By removing these characters, it becomes possible to make the correction.

…tains a certain error in which it presents invalid characters at the end, thus making the purpose of the patch inaccessible. In the original, at the end of each code (47505257 and 58505257, respectively, there is a number 02). Without these characters now, it becomes possible to make the correction correctly.
@TonyOps TonyOps changed the title This fix is intended to correct the GPRW to XPRW patch because it con… This fix is intended to correct the GPRW to XPRW patch Apr 5, 2023
@@ -20,15 +20,15 @@
<key>Enabled</key>
<true/>
<key>Find</key>
<data>R1BSVwI=</data>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original codes return a blank information upon saving and restarting the machine, which renders the GPRW patch ineffective. It only works when the code correction I included in the pull request is applied because with my changes, the patch is correctly implemented, ensuring that the function is executed as expected and as described in the documentation.

<key>Limit</key>
<integer>0</integer>
<key>Mask</key>
<data></data>
<key>OemTableId</key>
<data></data>
<key>Replace</key>
<data>WFBSVwI=</data>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original codes return a blank information upon saving and restarting the machine, which renders the GPRW patch ineffective. It only works when the code correction I included in the pull request is applied because with my changes, the patch is correctly implemented, ensuring that the function is executed as expected and as described in the documentation.

@TonyOps
Copy link
Author

TonyOps commented Nov 4, 2023

What actually prevents the patch from being applied?

The documentation itself contains an error. When downloading the .plist file at this link: SSDT-GPRW.aml and following the documentation to implement the patch, we encounter additional codes, specifically within the ACPI/Patch/0/find of type "Data" and in ACPI/Patch/0/replace of type "Data," the codes (47505257 02 and 58505257 02, respectively).

What causes this?

The code causing the error is the "02" at the end of both codes. It acts as if it were some kind of "dirty code," preventing the patch from being applied, rendering this configuration useless.



Solution and how it reflects in practice


To discover the correct code, it is necessary to remove the last two characters from both codes, that is, remove the final "02," making it possible to obtain the numbers (47505257 and 58505257). When converted again, they generate the codes "R1BSVw==" and "WFBSVw==."


By following these additional steps, any GPRW errors within macOS are eliminated.

@TonyOps TonyOps changed the title This fix is intended to correct the GPRW to XPRW patch Fix on OpenCore (GPRW to XPRW) Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant