-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix on OpenCore (GPRW to XPRW) #128
base: master
Are you sure you want to change the base?
Conversation
…tains a certain error in which it presents invalid characters at the end, thus making the purpose of the patch inaccessible. In the original, at the end of each code (47505257 and 58505257, respectively, there is a number 02). Without these characters now, it becomes possible to make the correction correctly.
@@ -20,15 +20,15 @@ | |||
<key>Enabled</key> | |||
<true/> | |||
<key>Find</key> | |||
<data>R1BSVwI=</data> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original codes return a blank information upon saving and restarting the machine, which renders the GPRW patch ineffective. It only works when the code correction I included in the pull request is applied because with my changes, the patch is correctly implemented, ensuring that the function is executed as expected and as described in the documentation.
<key>Limit</key> | ||
<integer>0</integer> | ||
<key>Mask</key> | ||
<data></data> | ||
<key>OemTableId</key> | ||
<data></data> | ||
<key>Replace</key> | ||
<data>WFBSVwI=</data> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original codes return a blank information upon saving and restarting the machine, which renders the GPRW patch ineffective. It only works when the code correction I included in the pull request is applied because with my changes, the patch is correctly implemented, ensuring that the function is executed as expected and as described in the documentation.
What actually prevents the patch from being applied?The documentation itself contains an error. When downloading the .plist file at this link: SSDT-GPRW.aml and following the documentation to implement the patch, we encounter additional codes, specifically within the ACPI/Patch/0/find of type "Data" and in ACPI/Patch/0/replace of type "Data," the codes (47505257 02 and 58505257 02, respectively). What causes this?The code causing the error is the "02" at the end of both codes. It acts as if it were some kind of "dirty code," preventing the patch from being applied, rendering this configuration useless. Solution and how it reflects in practiceTo discover the correct code, it is necessary to remove the last two characters from both codes, that is, remove the final "02," making it possible to obtain the numbers (47505257 and 58505257). When converted again, they generate the codes "R1BSVw==" and "WFBSVw==." By following these additional steps, any GPRW errors within macOS are eliminated. |
This fix is intended to correct the GPRW to XPRW patch, as it contains a certain error that presents invalid characters at the end, making the purpose of the patch inaccessible. In the original, at the end of each code (47505257 and 58505257, respectively), there is the number 02. By removing these characters, it becomes possible to make the correction.