-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🪲 fixed "Error: TypeError: Cannot read properties of undefined (readi… #247
base: main
Are you sure you want to change the base?
Conversation
…ng 'split')" if failure element is empty
@uebelack, could you please fix all CI and I will merge it. Thanks for your help |
The bug with calling We will add the new unit test from this PR, but the change in the |
And the new |
it('report from jest in junit format', async () => { | ||
const fixturePath = path.join(__dirname, 'fixtures', 'external', 'java', 'test-report-jest.xml') | ||
const trackedFilesPath = path.join(__dirname, 'fixtures', 'external', 'java', 'files.txt') | ||
const outputPath = path.join(__dirname, '__outputs__', 'pulsar-test-results.md') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pulsar-test-results.md
output file is used by another test.
@@ -19,6 +19,6 @@ export function parseIsoDate(str: string): Date { | |||
} | |||
|
|||
export function getFirstNonEmptyLine(stackTrace: string): string | undefined { | |||
const lines = stackTrace?.split(/\r?\n/g) | |||
return lines?.find(str => !/^\s*$/.test(str)) | |||
const lines = stackTrace ? stackTrace.split(/\r?\n/g) : [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is no longer necessary - see #258
…ng 'split')" if failure element is empty
closes #159
closes #241