Feature/#43 implement decorators #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
these classes are application level objects that should receive injections
was not able to use @bindable on getter or setter functions. Decorating them caused the parameter injection workflow to take place. This means if you set up getter/setter methods on private properties you have to call this.notify manually. Otherwise you can declare any public property as bindable. Perhaps it is possible to set up @bindable on the class and get the original property definitions that way. Something to consider next release.
always access context using a provided reference to ensure sand boxing
we want people to use the imperative form of injection to cut down on file size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds decorators for injection and data binding