Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cmake example #381

Merged
merged 10 commits into from
Nov 17, 2023
Merged

add cmake example #381

merged 10 commits into from
Nov 17, 2023

Conversation

XxChang
Copy link
Collaborator

@XxChang XxChang commented Nov 14, 2023

Please see README.md for details

Thanks

@haixuanTao
Copy link
Collaborator

haixuanTao commented Nov 14, 2023

Thanks!

Would it be possible to add it to the github action ci.yml as follows:

      - name: "Cmake example"
        timeout-minutes: 30
        run: cargo run --example cmake-dataflow

@XxChang
Copy link
Collaborator Author

XxChang commented Nov 14, 2023

This example only works on Linux right now. I don't have chance to fix it on Windows and MacOS, also I'm not good at Windows and MacOS. So I only check it on Linux by adding if: runner.os == 'Linux'

Sorry about that.

@haixuanTao
Copy link
Collaborator

haixuanTao commented Nov 16, 2023

Looks good to me. @phil-opp , could you have a quick look, as i don't have that much experience in CMake. Thanks!

Copy link
Collaborator

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have much cmake experience either, but I think this looks all reasonable. Thanks for the contribution!

@haixuanTao haixuanTao merged commit 408d13a into dora-rs:main Nov 17, 2023
17 checks passed
@haixuanTao
Copy link
Collaborator

Thanks @phil-opp , guess we´ll both learn this way :)

@haixuanTao haixuanTao mentioned this pull request Nov 17, 2023
@haixuanTao haixuanTao mentioned this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants