-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.3.0 #371
Release v0.3.0 #371
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Maybe we could reorder the changelog for v0.3 a bit to list the larger/breaking PRs first?
…e corresponding to the architecture
Sure. I have replaced a fixed cache alignement with the constant aligned_vec cache alignment that is based on architecture. // https://rust-lang.github.io/hashbrown/src/crossbeam_utils/cache_padded.rs.html#128-130
pub const CACHELINE_ALIGN: usize = {
#[cfg(any(
target_arch = "x86_64",
target_arch = "aarch64",
target_arch = "powerpc64",
))]
{
128
}
#[cfg(any(
target_arch = "arm",
target_arch = "mips",
target_arch = "mips64",
target_arch = "riscv64",
))]
{
32
}
#[cfg(target_arch = "s390x")]
{
256
}
#[cfg(not(any(
target_arch = "x86_64",
target_arch = "aarch64",
target_arch = "powerpc64",
target_arch = "arm",
target_arch = "mips",
target_arch = "mips64",
target_arch = "riscv64",
target_arch = "s390x",
)))]
{
64
}
}; Because, it was breaking the pip CI that is cross-compiling for Normally, this should be cross-architecture compatible as we are sending it as a slice. |
The alignment is not about cache lines here, it's about the alignment required by arrow types. So instead of making it platform dependent, we should replace the (I missed that |
Ok make sense. Thanks. Will do the change. |
No description provided.