Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beautify graph visualisation #370

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

haixuanTao
Copy link
Collaborator

This PR:

Removes the encapsulation of single operator making it visually more appealing and more consistent with the graph description.

See:

Old:

Screenshot 2023-10-31 at 11-49-19 Screenshot

New:

Screenshot 2023-10-31 at 11-49-40 Screenshot

It also use the base theme that is more visually appealing:

Old:

Screenshot 2023-10-31 at 11-49-40 Screenshot

New:

Screenshot 2023-10-31 at 11-52-28 Screenshot

Copy link
Collaborator

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@phil-opp phil-opp merged commit ae88b50 into refactor-python-typing Oct 31, 2023
17 checks passed
@phil-opp phil-opp deleted the simplify-graph-visualisation branch October 31, 2023 11:44
@phil-opp
Copy link
Collaborator

Ah sorry, you probably wanted to merge #369 first. I didn't see that this PR was targeting a different branch...

@haixuanTao
Copy link
Collaborator Author

It's ok :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants