Returning error as the last argument mangles '%s' and co. #388
Labels
Comments
mstoykov
added a commit
to mstoykov/goja
that referenced
this issue
May 16, 2022
mstoykov
added a commit
to mstoykov/goja
that referenced
this issue
May 16, 2022
Gabri3l
pushed a commit
to mongodb-forks/goja
that referenced
this issue
Sep 1, 2022
(cherry picked from commit 4418d45)
Gabri3l
added a commit
to mongodb-forks/goja
that referenced
this issue
Mar 15, 2023
* Fixed panic in newArrayFromIter when the iterator is already closed. Fixes dop251#375 * Fixed panic when parsing invalid object property keys. Fixes dop251#376. * Fixed accidental shadowing in the else branches of type assertion * Fixed defineProperty("length") for arrays. Improved detection of non-standard array configurations. Upgraded tc39 tests. * Return true values of struct fields or reflect slice elements, rather than pointers to them. Closes dop251#378. * Upgraded dependencies. Closes dop251#380. * Implemented exponentiation expressions. Closes dop251#381. * Enabled tests that use ** operator. Some array fixes as a result. * Implemented nullish coalescing operator (??). Closes dop251#382. * Implemented `{Array,String,%TypedArray%}.prototype.at` (dop251#384)e7c2872c8) * Fixed callee expressions in optional chains. Fixes dop251#385. * Do not use fmt.Sprintf() for plain error strings. Fixes dop251#388. * Implemented 'copy-on-change' mechanism for inner compound values. Fixes dop251#403. * Fixed objectGoReflect equality. See dop251#403 * Don't clear interrupt until the stack is empty (dop251#405) * test: skip Promise based tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Returning error as the last argument mangles the final
.Error()result as it goes throughfmt.Sprintfwith no arguments which makes all fmt verbs to becomeMISSING.The fix seems to be to just not run through fmt when it's not needed 🤷
Originally reported in grafana/k6#2537
The text was updated successfully, but these errors were encountered: