doom-rouge-brighter-comments does not change comment colour

[crestofthebeast]

Theme(s)

doom-rouge

What were you expecting?

(setq doom-rouge-brighter-comments t) to enable a brighter comment colour

What actually happened?

i get default(?) comment behaviour/colours

some screenshots. each was taken after changing the (setq doom-rouge-brighter-comments ) line, then saving/tangling, hitting space h r r, and restarting emacs.

Steps to reproduce

1. switch to doom-rouge theme
2. setq doom-rouge-brighter-comments to t
3. save config.org/el
4. restart emacs
5. open a file with comments in it
6. weep, for you wanted brighter comments

Operating system

macOS Ventura 13.2.1

Emacs version

GNU Emacs 28.2 (builh 1, aarch-apple-darwin22.3.0, Carbon Version 169 Appkit 2299.4) of 2023-02-25

Installed commit of doom-themes

should be 4c239db

[hlissner]

Ah. Seems the theme never uses the variables. I'll get around to fixing this when I can, but PRs are welcome, in the meantime.

[crestofthebeast]

will try to give a PR a crack later today, since i've been meaning to learn doom's theme structure.

[hlissner]

Do you have any recommendations for what color to use for the brighter comments? I'm playing with violet, or a violet+red blend, but I'm not sure it fits the asthetic (or is bright enough):

base5 (original)

violet

violet + red