Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

invalid preview key on the latest consult #7064

Closed
LemonBreezes opened this issue Feb 1, 2023 · 8 comments
Closed

invalid preview key on the latest consult #7064

LemonBreezes opened this issue Feb 1, 2023 · 8 comments
Labels
is:bug Something isn't working as intended needs-triage Issue hasn't been assessed yet

Comments

@LemonBreezes
Copy link
Contributor

LemonBreezes commented Feb 1, 2023 •
edited
Loading

image
This block is causing an Invalid preview key: [67108896] error because (key-valid-p (kbd "C-SPC")) returns nil.

System Information

https://pastebin.com/L1fVW6d8
@LemonBreezes LemonBreezes added is:bug Something isn't working as intended needs-triage Issue hasn't been assessed yet labels Feb 1, 2023
@b40yd
Copy link
Contributor

b40yd commented Feb 2, 2023 •
edited
Loading

this problem need rewrite :preview-key (kbd "C-SPC") to :preview-key "C-<SPC>".

@akaihola
Copy link

akaihola commented Feb 3, 2023 •
edited
Loading

I also see this when typing C-c f r in nix-doom-emacs:

kuva

@akaihola akaihola mentioned this issue Feb 3, 2023
Open
@akaihola
Copy link

akaihola commented Feb 4, 2023

Is there any work-around I can use in my Emacs configuration file?

@ghosty141
Copy link

@minad I'm wondering is C-SPC actually invalid or did something change, I also had C-SPC bound in my config (not related to doom emacs though) and currently I too get this error/warning.

@minad
Copy link
Contributor

minad commented Feb 4, 2023

@ghosty141 I updated the key configuration to use the new key format. See also the changelog. I clarified the message in minad/consult@982ec0b.

@ghosty141
Copy link

I see, so basically it was always invalid and kbd was just very permissive. That clarifies it, thank you.

@minad
Copy link
Contributor

minad commented Feb 4, 2023 •
edited
Loading

No, the difference is that instead of :preview-key (kbd "C-SPC") you should just write :preview-key "C-SPC". The value of (kbd "C-SPC") is [67108896], which is what you see in the error message. See also the updated example configuration: https://github.com/minad/consult#use-package-example.

@ghosty141
Copy link

Funnily enough I just found that out myself, thanks for clarifying though!

alexmurray added a commit to alexmurray/dot_emacs.d that referenced this issue Feb 9, 2023
@alexmurray
Don't use kdb with :preview-key for consult
776c3bb 
doomemacs/doomemacs#7064 (comment)

Signed-off-by: Alex Murray <[email protected]>
@minad minad mentioned this issue Feb 9, 2023
Closed
iyefrat added a commit to iyefrat/doom-emacs that referenced this issue Feb 11, 2023
@iyefrat
bump: :completion vertico compat consult-lsp magit git-commit
2c3930d 
emacs-straight/compat@7ca7d300d1d2 -> emacs-straight/compat@2bedcb5ea919
mhayashi1120/Emacs-wgrep@f9687c28bbc2 -> mhayashi1120/Emacs-wgrep@edf768732a56
minad/consult-flycheck@7a10be316d72 -> minad/consult-flycheck@51b1b48e8dad
minad/consult@16b2dc5e34c8 -> oantolin/orderless@ae849b3d9f8c
minad/marginalia@c1365bf0c7b5 -> minad/marginalia@6d48ed54be87
minad/vertico@bedd146c3ffc -> minad/vertico@f303790546ed
oantolin/embark@629cce948c56 -> oantolin/embark@4882b395cef9
oantolin/orderless@847694e78c12 -> minad/vertico@f303790546ed
tumashu/vertico-posframe@a3d0802d7b4a -> tumashu/vertico-posframe@790f74b49d53
gagbo/consult-lsp@58b541476203 -> gagbo/consult-lsp@f8db3252c0da
magit/magit@0ef98ef51811 -> magit/magit@6d325d90ba13

consult-lsp needed to be bumped to work with some changed consult
internals, and due to compat shenanigans we have to bump magit to latest
as well.

Includes fixes to stay up to date with upstream api changes to.
consult-customize and the deprecation of embark-define-keymap

Close: doomemacs#7064
simonfxr added a commit to simonfxr/doomemacs that referenced this issue Feb 12, 2023
@simonfxr
Squashed commit of the following:
58ab08b 
commit d31566a
Author: Itai Y. Efrat <[email protected]>
Date:   Thu Feb 9 21:17:51 2023 +0200

    feat(vertico): remap Info-search to consult-info

commit 2c3930d
Author: Itai Y. Efrat <[email protected]>
Date:   Thu Feb 9 01:42:21 2023 +0200

    bump: :completion vertico compat consult-lsp magit git-commit

    emacs-straight/compat@7ca7d300d1d2 -> emacs-straight/compat@2bedcb5ea919
    mhayashi1120/Emacs-wgrep@f9687c28bbc2 -> mhayashi1120/Emacs-wgrep@edf768732a56
    minad/consult-flycheck@7a10be316d72 -> minad/consult-flycheck@51b1b48e8dad
    minad/consult@16b2dc5e34c8 -> oantolin/orderless@ae849b3d9f8c
    minad/marginalia@c1365bf0c7b5 -> minad/marginalia@6d48ed54be87
    minad/vertico@bedd146c3ffc -> minad/vertico@f303790546ed
    oantolin/embark@629cce948c56 -> oantolin/embark@4882b395cef9
    oantolin/orderless@847694e78c12 -> minad/vertico@f303790546ed
    tumashu/vertico-posframe@a3d0802d7b4a -> tumashu/vertico-posframe@790f74b49d53
    gagbo/consult-lsp@58b541476203 -> gagbo/consult-lsp@f8db3252c0da
    magit/magit@0ef98ef51811 -> magit/magit@6d325d90ba13

    consult-lsp needed to be bumped to work with some changed consult
    internals, and due to compat shenanigans we have to bump magit to latest
    as well.

    Includes fixes to stay up to date with upstream api changes to.
    consult-customize and the deprecation of embark-define-keymap

    Close: doomemacs#7064

# Conflicts:
#	modules/emacs/vc/packages.el
#	modules/tools/magit/packages.el
@c6c7 c6c7 mentioned this issue Feb 13, 2023
Merged
mrcnski added a commit to mrcnski/init.el that referenced this issue Feb 14, 2023
@mrcnski
Fix "Invalid preview key" message in minibuffer
9f5b416 
The consult-customize function will now report a message when
using (kbd ...) as a value for the :preview-key.

See doomemacs/doomemacs#7064
See
purcell/emacs.d@289a748
0xMF pushed a commit to 0xMF/emacs.d that referenced this issue Feb 14, 2023
@c6c7 @0xMF
[minibuffer] Fix "Invalid preview key" message in minibuffer
126f41e 
The consult-customize function will now report a message when
using (kbd ...) as a value for the :preview-key.

See doomemacs/doomemacs#7064.
Spike-Leung pushed a commit to Spike-Leung/emacs.d that referenced this issue Feb 15, 2023
@c6c7 @Spike-Leung
[minibuffer] Fix "Invalid preview key" message in minibuffer
4e3de5f 
The consult-customize function will now report a message when
using (kbd ...) as a value for the :preview-key.

See doomemacs/doomemacs#7064.
Spike-Leung pushed a commit to Spike-Leung/emacs.d that referenced this issue Feb 15, 2023
@c6c7 @Spike-Leung
[minibuffer] Fix "Invalid preview key" message in minibuffer
3d55580 
The consult-customize function will now report a message when
using (kbd ...) as a value for the :preview-key.

See doomemacs/doomemacs#7064.
xiliuya pushed a commit to xiliuya/emacs.d that referenced this issue Feb 15, 2023
@c6c7 @xiliuya
[minibuffer] Fix "Invalid preview key" message in minibuffer
ed0cbfe 
The consult-customize function will now report a message when
using (kbd ...) as a value for the :preview-key.

See doomemacs/doomemacs#7064.
abcdw pushed a commit to abcdw/rde that referenced this issue Feb 16, 2023
rde: emacs-completion: Adjust keybinding to latest consult version.
decdfe7 
See doomemacs/doomemacs#7064.
douo added a commit to douo/lims_dot_emacs that referenced this issue Feb 17, 2023
@douo
consult: fix invalid preview key
4ffd836 
doomemacs/doomemacs#7064
SadSock pushed a commit to SadSock/doomemacs that referenced this issue Feb 19, 2023
@iyefrat @SadSock
bump: :completion vertico compat consult-lsp magit git-commit
47773d3 
emacs-straight/compat@7ca7d300d1d2 -> emacs-straight/compat@2bedcb5ea919
mhayashi1120/Emacs-wgrep@f9687c28bbc2 -> mhayashi1120/Emacs-wgrep@edf768732a56
minad/consult-flycheck@7a10be316d72 -> minad/consult-flycheck@51b1b48e8dad
minad/consult@16b2dc5e34c8 -> oantolin/orderless@ae849b3d9f8c
minad/marginalia@c1365bf0c7b5 -> minad/marginalia@6d48ed54be87
minad/vertico@bedd146c3ffc -> minad/vertico@f303790546ed
oantolin/embark@629cce948c56 -> oantolin/embark@4882b395cef9
oantolin/orderless@847694e78c12 -> minad/vertico@f303790546ed
tumashu/vertico-posframe@a3d0802d7b4a -> tumashu/vertico-posframe@790f74b49d53
gagbo/consult-lsp@58b541476203 -> gagbo/consult-lsp@f8db3252c0da
magit/magit@0ef98ef51811 -> magit/magit@6d325d90ba13

consult-lsp needed to be bumped to work with some changed consult
internals, and due to compat shenanigans we have to bump magit to latest
as well.

Includes fixes to stay up to date with upstream api changes to.
consult-customize and the deprecation of embark-define-keymap

Close: doomemacs#7064
aieu pushed a commit to vgist/emacs.d that referenced this issue Feb 20, 2023
@c6c7 @aieu
[minibuffer] Fix "Invalid preview key" message in minibuffer
7534c22 
The consult-customize function will now report a message when
using (kbd ...) as a value for the :preview-key.

See doomemacs/doomemacs#7064.
shartf added a commit to shartf/doomemacs that referenced this issue Feb 21, 2023
@shartf
Fix bug in binding C-SPC to consult, causing the "Invalid preview key…
d5620d9 
…: [67108896]" error

Related to bug
 doomemacs#7064
Was causing the mentioned error in themes preview
@shartf shartf mentioned this issue Feb 21, 2023
Merged
5 tasks
hlissner pushed a commit that referenced this issue Feb 21, 2023
@shartf
fix(vertico): consult-theme: invalid preview key error
92c9e93 
Fix: #7064
Amend: 642f88a
@sebhahn sebhahn mentioned this issue Feb 21, 2023
Merged
SadSock pushed a commit to SadSock/doomemacs that referenced this issue Feb 22, 2023
@shartf @SadSock
fix(vertico): consult-theme: invalid preview key error
5667c8d 
Fix: doomemacs#7064
Amend: 642f88a
skykanin pushed a commit to skykanin/doomemacs that referenced this issue Mar 13, 2023
@iyefrat @skykanin
bump: :completion vertico compat consult-lsp magit git-commit
1f3eb42 
emacs-straight/compat@7ca7d300d1d2 -> emacs-straight/compat@2bedcb5ea919
mhayashi1120/Emacs-wgrep@f9687c28bbc2 -> mhayashi1120/Emacs-wgrep@edf768732a56
minad/consult-flycheck@7a10be316d72 -> minad/consult-flycheck@51b1b48e8dad
minad/consult@16b2dc5e34c8 -> oantolin/orderless@ae849b3d9f8c
minad/marginalia@c1365bf0c7b5 -> minad/marginalia@6d48ed54be87
minad/vertico@bedd146c3ffc -> minad/vertico@f303790546ed
oantolin/embark@629cce948c56 -> oantolin/embark@4882b395cef9
oantolin/orderless@847694e78c12 -> minad/vertico@f303790546ed
tumashu/vertico-posframe@a3d0802d7b4a -> tumashu/vertico-posframe@790f74b49d53
gagbo/consult-lsp@58b541476203 -> gagbo/consult-lsp@f8db3252c0da
magit/magit@0ef98ef51811 -> magit/magit@6d325d90ba13

consult-lsp needed to be bumped to work with some changed consult
internals, and due to compat shenanigans we have to bump magit to latest
as well.

Includes fixes to stay up to date with upstream api changes to.
consult-customize and the deprecation of embark-define-keymap

Close: doomemacs#7064
skykanin pushed a commit to skykanin/doomemacs that referenced this issue Mar 13, 2023
@shartf @skykanin
fix(vertico): consult-theme: invalid preview key error
3656516 
Fix: doomemacs#7064
Amend: 642f88a
tommas1988 pushed a commit to tommas1988/emacs.d that referenced this issue Jan 1, 2024
@c6c7 @tommas1988
[minibuffer] Fix "Invalid preview key" message in minibuffer
2da1a2c 
The consult-customize function will now report a message when
using (kbd ...) as a value for the :preview-key.

See doomemacs/doomemacs#7064.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
is:bug Something isn't working as intended needs-triage Issue hasn't been assessed yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@akaihola @minad @b40yd @ghosty141 @LemonBreezes