This repository has been archived by the owner on Apr 16, 2024. It is now read-only.
colorscheme, terminal and luacheck fixes #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edwin Török <[email protected]>
event=ColorScheme didn't work on the first colorscheme application on startup, but only on a 2nd manual one (either by running 'colorscheme' again, or 'doautocmd ColorScheme'). Since we want to run this on startup anyway, just remove the 'event'. Signed-off-by: Edwin Török <[email protected]>
It might define autocommands on ColorScheme, if we set it too early then these autocommands wouldn't have been registered yet. Signed-off-by: Edwin Török <[email protected]>
Checking lua/doom/modules/features/lsp/init.lua 1 warning
lua/doom/modules/features/lsp/init.lua:214:9: unused variable source_map
Checking lua/doom/modules/langs/cc/init.lua 1 warning
lua/doom/modules/langs/cc/init.lua:1:7: unused variable utils
Signed-off-by: Edwin Török <[email protected]>
NTBBloodbath
approved these changes
Oct 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small bugfixes, I thought to gather them into a single PR.
Line numbers in terminal are confusing, so I disabled them.
indentlines wasn't always loading properly, and the colorscheme was being loaded too early (before processing user config).
Also luacheck had 2 warnings that caused a CI failure in my other PR, so fixing that too.