GHI #20 Add missing quotes

doodspav · Dec 21, 2023 · 7c11fdf · 7c11fdf
1 parent ffb74fe
commit 7c11fdf
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/.github/workflows/reusable-test-native.yml b/.github/workflows/reusable-test-native.yml
@@ -107,7 +107,8 @@ jobs:
           cmake --preset ${{ env.CMAKE_PRESET }} -DBUILD_TESTING=OFF -DCMAKE_CXX_FLAGS="" -DBUILD_SHARED_LIBS=${{ matrix.cmake_build_shared }} -DCMAKE_BUILD_TYPE=${{ matrix.cmake_build_type }} -Dgtest_force_shared_crt=ON -Dgtest_hide_internal_symbols=ON ..
           cmake --build . --verbose --config ${{ matrix.cmake_build_type }}
           cmake --install . --config ${{ matrix.cmake_build_type }} --prefix install
-      
+
+      # TODO: figure out how to cache this for builds where we don't change any source code
       - name: Build patomic
         if: env.SKIP_JOB != 'true'
         run: |

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -177,7 +177,7 @@ jobs:
           dir_names=(test-coverage-internal/*)
           
           # all directories have the same root path
-          root_path="test-coverage-internal/${dir_names[0]}/patomic.rootpath
+          root_path="test-coverage-internal/${dir_names[0]}/patomic.rootpath"
           
           # save path for future steps
           echo "root_compilation_dir=${root_path}" >> $GITHUB_OUTPUT
@@ -191,13 +191,12 @@ jobs:
       - name: Create Lcov Config File
         run: |
           touch lcovrc
-          
           echo "genhtml_hi_limit = ${{ env.HI_LIMIT }}" >> lcovrc
           echo "genhtml_med_limit = ${{ env.MED_LIMIT }}" >> lcovrc
           echo "genhtml_function_hi_limit = ${{ env.HI_LIMIT }}" >> lcovrc
           echo "genhtml_function_med_limit = ${{ env.MED_LIMIT }}" >> lcovrc
           
-          echo "Contents of lcovrc:
+          echo "Contents of lcovrc:"
           cat lcovrc
 
       - name: Generate HTML Files