GLTFLoader: Implement KHR_draco_mesh_compression. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my case for example I have a listener to the mousedown event. In this listener I check for the current set axis. But of course it is ```null``` because it is set just after the event was triggered. So my suggestion is to set the axis and AFTERWARDS trigger the event.
|
Nice, thanks for the ping @donmccurdy! |
donmccurdy
force-pushed
the
feat-gltf-draco-extension-v4
branch
2 times, most recently
from
537a602 to
aef4616
Compare
Propagate VR-mode upon link traversal so the the user doesn't have to manually click on the 'enter VR' button each time.
donmccurdy
force-pushed
the
feat-gltf-draco-extension-v4
branch
from
aef4616 to
fb723e9
Compare
Simple case: 1. Load GLTF File with Specular-Glosiness-Material so the ```refreshUnfiorms``` function is being set ```mesh.onBeforeRender = extensions[ EXTENSIONS.KHR_MATERIALS_PBR_SPECULAR_GLOSSINESS ].refreshUniforms;``` 2. Use an override material for the scene to render, for example use the SAOPass. 3. Get error because u try to work with uniforms of a material which doesn't have any Suggestion: Simple check if the material has the property ```isGLTFSpecularGlossinessMaterial``` and it is true. Because the ```refreshUniforms``` function is only set if it is true.
Matrix4 - description for matrix and matrixWorld items in mrdoob#13183
WebVR.js: Automatically enter VR on vrdisplayactivate event.
Update google-closure-compiler
Matrix4 - fix documentation on matrix and matrixWorld
mirror nodes fixes
webgl_materials_envmaps: Remove unused variable
Examples: Add demo for indexed BufferGeometry
InputNode readonly option
* Updated DRACOLoader * Changed to request attribute only by unique id * Added support for skinning * Added more sample models
donmccurdy
force-pushed
the
feat-gltf-draco-extension-v4
branch
from
8b925c8 to
7d95279
Compare
donmccurdy
force-pushed
the
feat-gltf-draco-extension-v4
branch
from
c8a09a1 to
ef9ffde
Compare
donmccurdy
force-pushed
the
feat-gltf-draco-extension-v4
branch
from
938ca04 to
ab8b634
Compare
donmccurdy
pushed a commit
that referenced
this pull request
Apr 20, 2019
donmccurdy
pushed a commit
that referenced
this pull request
Sep 2, 2021
…terial (mrdoob#16912) * Add feature to LineMaterial to support toggling screen-space line width * Change lines parameter * remove magic number scaling * change if to use mix function * build jsm * rename variable to size attenuation, use defines * Add perspective attenuation with width in world units * Update comments * Add jsm build * revert statement position * Change sizeAttenuation to worldUnits * Fix endcaps not being perpendicular to line direction * Update js examples version * Make line look like a capsule (#6) * update js file * Update comments * Add a tighter containment for capsule * update module * small adjustment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @fanzhanggoogle @pjcozzi Expected three.js changes for KHR_draco_mesh_compression. Note this depends on google/draco#315.