Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify email upon sign-up #30

Closed
iam1980 opened this issue Mar 9, 2013 · 10 comments
Closed

Verify email upon sign-up #30

iam1980 opened this issue Mar 9, 2013 · 10 comments
Milestone

Comments

@iam1980
Copy link

iam1980 commented Mar 9, 2013

Is anyone planning on implementing this?

@donjakobo
Copy link
Owner

I haven't thought of adding it... all yours :)

@donjakobo
Copy link
Owner

@AdwinTrave did you add this to your CI3 branch?

@StorytellerCZ
Copy link
Collaborator

@donjakobo No, I don't have this feature yet. I will work on it, but currently other task have taken priority.

@StorytellerCZ
Copy link
Collaborator

Presently working on this. Will be part of the next CI3 merge. After we test it more in the CI3 branch I will port it back to to CI2 branch as well.

@StorytellerCZ
Copy link
Collaborator

Done, will be merging soon.
Upon sign-up an email will be send to verify user e-mail address. There is an option that will stop user for signing in until their email is verified (at the same time I've also added made sure that it checks that the user isn't suspended).

So the basic thing is done, now more things can be added like, resends and reminders in user settings if the user hasn't verified their e-mail.

@donjakobo
Copy link
Owner

Thanks for the commit, I'll review and merge.

donjakobo added a commit that referenced this issue Nov 19, 2013
CLOSE #30 + CI3 update + little improvements and fixes
@StorytellerCZ
Copy link
Collaborator

I think that this is done in the CI3 version.

@donjakobo I found this: https://github.com/EllisLab/CodeIgniter/wiki/A3M-Account-Authentication-and-Authorization
I think we should probably update it. Also it might not hurt to start putting version number on our progress again. Hence "officially" release the current progress as version 0.7 and keep track of changes for the future. If we want we can then port features like this one from the CI3 branch and release version 0.8
What are your thoughts?

@donjakobo
Copy link
Owner

We can do that, the numbering I would try to stick to say v1.0 being CI 2.X as typically the X.Y is X = major, Y = minor.

Also, CI 3 would be at least a jump to 2.0 since it is a huge architectural change and not compatible with the previous 1.X

Thoughts? I typically jump from 1.Y -> 2.Y if we change something big time (like Bootstrap 2x -> 3.x) or php dependancies like CI 2.x to CI 3.x

@StorytellerCZ
Copy link
Collaborator

I would go as far as X.Y.Z
X - major
Y - minor
Z - patch

I agree with having the current CI2 branch being 1.Y and the CI 3 being 2.Y, it makes sense.

If you are fine with that I will create milestones so that we can separate issues based on which version they are related to.

@donjakobo
Copy link
Owner

yeah, Z for patch is preferred, I just forgot to mention it ;) 👍
work has been completed on version v1.0

If you want you can setup a tag for the CI3 as well, I will go and update the Ellislab wiki

StorytellerCZ pushed a commit that referenced this issue Dec 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants