-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify email upon sign-up #30
Comments
I haven't thought of adding it... all yours :) |
@AdwinTrave did you add this to your CI3 branch? |
@donjakobo No, I don't have this feature yet. I will work on it, but currently other task have taken priority. |
Presently working on this. Will be part of the next CI3 merge. After we test it more in the CI3 branch I will port it back to to CI2 branch as well. |
Done, will be merging soon. So the basic thing is done, now more things can be added like, resends and reminders in user settings if the user hasn't verified their e-mail. |
Thanks for the commit, I'll review and merge. |
CLOSE #30 + CI3 update + little improvements and fixes
I think that this is done in the CI3 version. @donjakobo I found this: https://github.com/EllisLab/CodeIgniter/wiki/A3M-Account-Authentication-and-Authorization |
We can do that, the numbering I would try to stick to say v1.0 being CI 2.X as typically the X.Y is X = major, Y = minor. Also, CI 3 would be at least a jump to 2.0 since it is a huge architectural change and not compatible with the previous 1.X Thoughts? I typically jump from 1.Y -> 2.Y if we change something big time (like Bootstrap 2x -> 3.x) or php dependancies like CI 2.x to CI 3.x |
I would go as far as X.Y.Z I agree with having the current CI2 branch being 1.Y and the CI 3 being 2.Y, it makes sense. If you are fine with that I will create milestones so that we can separate issues based on which version they are related to. |
yeah, Z for patch is preferred, I just forgot to mention it ;) 👍 If you want you can setup a tag for the CI3 as well, I will go and update the Ellislab wiki |
Is anyone planning on implementing this?
The text was updated successfully, but these errors were encountered: