feat: enable specifying irsa or role permissions for flyte module #319
+78
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gusmann Can you elaborate on what you mean with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Domino team,
The flyte submodule seems to expect IRSA to be configured on the target EKS cluster. While recommended, there are cases where IRSA isn't installed on an EKS cluster (i.e. following the default Domino EKS installation instructions). This PR allows a user to specify a flag that enables IRSA (disabled by default) and, if disabled, a role to use for attaching the required Flyte S3 policy. If the flag is enabled, instead of requiring the user to specify details about the target cluster, it simply uses the EKS cluster name to pull relevant details from AWS such as the OIDC provider URL/ARN (these can be computed based on the cluster's OIDC endpoint).
The result is less required variables and support for clusters that do not have EKS IRSA configured.