Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing urllib3 dependency #99

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Add missing urllib3 dependency #99

merged 2 commits into from
Jul 25, 2023

Conversation

ddl-gabrielhaim
Copy link
Collaborator

@ddl-gabrielhaim ddl-gabrielhaim commented Jul 25, 2023 •
edited
Loading

Description

Add missing urllib3 dependency

Related Issue

https://dominodatalab.atlassian.net/browse/DOM-48743

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

ddl-gabrielhaim and others added 2 commits July 25, 2023 10:08
@ddl-gabrielhaim
Add missing dependency on urllib3 (#98)
a30b382 
* Add missing urllib3 dependency

* Do not use version >2

* Bump version
@ddl-gabrielhaim
Bump to 5.7.1
11875fe
@ddl-gabrielhaim ddl-gabrielhaim changed the base branch from main to release-5.7 July 25, 2023 17:10
@ddl-gabrielhaim ddl-gabrielhaim merged commit dbcf423 into release-5.7 Jul 25, 2023
@ddl-gabrielhaim ddl-gabrielhaim deleted the gh/release-5.7/add-missing-urllib3-dep branch July 25, 2023 22:13
ddl-giuliocapolino added a commit that referenced this pull request Sep 1, 2023
@ddl-giuliocapolino @ddl-gabrielhaim
Mergeback release-5.7 (#112)
8596f4b 
* Update to 5.7.0 (#95)

* Update version and submodule dependecy to 5.7.0

* Use tab instead

* use streamlined branch name

* Add missing urllib3 dependency (#99)

* Add missing dependency on urllib3 (#98)

* Add missing urllib3 dependency

* Do not use version >2

* Bump version

* Bump to 5.7.1

* DataSource Audit: pass run_id from env variable (#102)

* flight meta middleware for extra metadata

* iteration on comments + add run id to http requests

* moving run id to parameter input

* adding client source environment variable

* cleanup

* updating pyproject version (#109)

---------

Co-authored-by: ddl-gabrielhaim <[email protected]>
Co-authored-by: Gabriel Haim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddl-joyce-zhao ddl-joyce-zhao ddl-joyce-zhao approved these changes

@ddl-giuliocapolino ddl-giuliocapolino Awaiting requested review from ddl-giuliocapolino

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ddl-gabrielhaim @ddl-joyce-zhao