add more feature view fields #86
Conversation
✅ Result of Pytest Coverage---------- coverage: platform linux, python 3.9.16-final-0 -----------
~ 55 passed in 83.67s (0:01:23) ~ |
| required: | ||
| - name | ||
| - features | ||
| - entities | ||
| - tags | ||
| - description |
There was a problem hiding this comment.
for description being required, are we going to pass in an empty one if the user doesn't define one?
There was a problem hiding this comment.
I checked feast FeatureView implementation, although it's optional when defining a FeatureView, feast will set the value to be an empty string if not provided. So when we are reading a FeatureView object, that field is always there.
| ttl=UNSET if fv.ttl is None else int(fv.ttl.total_seconds() * 1000), | ||
| tags=FeatureViewRequestTags.from_dict(fv.tags), | ||
| description=fv.description, |
There was a problem hiding this comment.
description isn't required field when making feature view, what if fv doesn't have a description?
There was a problem hiding this comment.
See my above comments. This field is am empty string if not provided when initializing the feature view.
domino_data/_feature_store/client.py
Outdated
| feature_views=feature_views, | ||
| git_commit_hash=commit_id, | ||
| project_id=project_id, | ||
| user_id=user_id, |
There was a problem hiding this comment.
should this come from the principal? or are we ok with it being passed by the client
ddl-joyce-zhao
deleted the
ddl-joyce-zhao.DOM-43536.add-more-feature-view-fields
branch
Description
Added more Feature view fields
Related Issue
https://dominodatalab.atlassian.net/browse/DOM-43536
Type of Change
Checklist
CONTRIBUTING.mdguide.make codestyle.